[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v7 00/11] Add Xue - console over USB 3 Debug Capability
- To: Jan Beulich <jbeulich@xxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 20 Sep 2022 01:38:22 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E1uP1fjcRXa+FFxfK+iSFV340Ed5Qip3Kuo10Mx4Qg8=; b=h4Vn2QgdXgpnVpQHfloY470u/P5o6I+vV9A5IfkReVTEUrfcKfYNInzJoHJDJePu7Ce7VjEYs4Es8FqYPQ5ipHEg66i2CiUd93cWuFU6WK0z3TKZqKwpEhD3eaGwejfJmAaxlqK1gLzd5Nylv0DL48BRM42G9z1ODAmZVYOrkUoDvEdsDCsh/XxcuYwgMczkKduOGd8iNQkUpvJQsNVABSYiT1MS7F6U+MhvJ9fb6iU5Omr4Adgg+XmQrb+aVv2ZCoXB92CBFXmh3uoADlzIiAYo45CQVgGbFF4DgHZgOJpufc/CHHgSu7i+h43hmEC/2+DUkvPj2+MCLKsdUtgyYw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E1uP1fjcRXa+FFxfK+iSFV340Ed5Qip3Kuo10Mx4Qg8=; b=mV0k+LL7oAoxYrbLt7DlYRBa7moMizVN+a5pJ4r9tTTeWXqt+/4Tpxt9EUBSUYpDvP6AgZ2sEBjgMOR2O/QGA1olE1qcljd9b+wOLzEIHPzbNkBW+pf3DpQ6rukOvDgSbsklwDR7vBp9BUGxEQ+eSMmr/jjCjWzuylFmpMsd3LSS7EQURnco+9sftmwjgQNF0uWlv+BobBjViVa6GKPQy/GudI7TaYA4WfeBieYe0Zw12HqRkg+y65FpfoLF5Oq2f6GaogCUbP0yIVdPDWuY+//sSokZkWrn53WuVAebkBGe9L/rFWbonCUiFhIn4XlBs+WKFP8Ep1RL41kMIoYvAg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cwT/NL6/+mGkLABhcQHCs0Z4wnTnwr0xjHliOmH+i+zFDy0eA8HGvSF4tr4RDndlbD7alPuViWSi9DXFzUSvMbZF2aodTSBoAIyf51nl6/qaEuHhmFleZR38Uj49fwVFAaqBsa8xs2HcopnqK99/pw4hTcddd5UTUSXpVYj50t4uT2N8M1wb04ZdvTLBmeLKtOtKz9GatfxYEl5F4A68L1fiyKPvl8Dgnw673jK7xnbuekMM32yTnVNnGHRgEYBq0h4woKLHUQd8ptjxFIBxOinwsR4+6Ul1dri1kWr8zNbwIOFr8n1pr2iVxbUcAbZ5APNBh1NKvI9eVYHEE2mAow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bLTdeFapy6i/7JP9PbX6oEahAa0sP67Nn0JLUaO8eKZP2W1Y9XT+vtaOEJrlLaMWnhODmra8LLU1HCjommttqI/hYn/1TxIyfJSTUc+1+W3mpg00ihvJhdMjFxRhGs3dhEL5/iZGs/6jSPN4RIM9ptHU4lWbBIA7PfIsRjxS5PJNYADRr/akUO5JUIkwCo4sLFQGMcdUxJBxdRBbP4D3RKs9166xxr1p/ms7PqqSC4PI8Q9xWdIbSZ+vbTkRcAaj9gmegFuzog1VxpNbicDMfwPy9hilmsxwyc4WXlYLSa3ruoi1P0i50UFA1g66LIiNcWUYZBtR9tHWQowsHDCQVQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 20 Sep 2022 01:38:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYykB84mg4uPAeVUC/H1cP2JLxkK3mxGyAgADG5TA=
- Thread-topic: [PATCH v7 00/11] Add Xue - console over USB 3 Debug Capability
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> > Marek Marczykowski-Górecki (11):
> > drivers/char: allow using both dbgp=xhci and dbgp=ehci
> > IOMMU: add common API for device reserved memory
> > IOMMU/AMD: wire common device reserved memory API
> > drivers/char: mark DMA buffers as reserved for the XHCI
> > drivers/char: add RX support to the XHCI driver
> > drivers/char: fix handling cable re-plug in XHCI console driver
> > drivers/char: allow driving the rest of XHCI by a domain while Xen uses
> DbC
> > IOMMU/VT-d: wire common device reserved memory API
> > console: support multiple serial console simultaneously
> > drivers/char: suspend handling in XHCI console driver
> > drivers/char: add console=ehci as an alias for console=dbgp
>
> Henry,
>
> this series is kind of on the edge between a feature submission and
> corrections to existing code, as the base patch introducing the new
> driver was merged only recently, and at least some of the things here
> aren't clearly "bug" fixes. Additionally it's on the side of larger
> ones considering the point in time.
>
> To summarize state: Patches 2-7 are ready to be committed, and Marek
> tells me that they're independent of patch 1 (except for a context
> conflict). Patch 11 probably also falls in this category. Patch 10,
> otoh, is pretty likely to be viewed as a new feature, and hence
> likely wants postponing. In any event - if I was to commit any of
> these, this couldn't happen earlier than next Monday, as the laptop
> I'm currently working with is not (yet) set up to do commits from.
>
> Do you have any particular opinion on the disposition of this series?
Thank you for the information and the detailed summary!
From the cover letter and the risk analysis from Marek, I am ok to
commit patch #2-#7 and patch#11, as long as they are independent
patches and will not break current driver. Thank you for taking care
of the committing :))
Since from the discussion earlier, the release-ack tag is a little bit too
early in this stage, it is up to you to add the release-ack tag when you
do the committing.
Kind regards,
Henry
>
> Thanks, Jan
|
