[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 00/11] Add Xue - console over USB 3 Debug Capability


  • To: Henry Wang <Henry.Wang@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 19 Sep 2022 15:33:55 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jrBA+O2CEsDVuJpb0NA0D6TzHQhOStL3qp5Kfu5RO2s=; b=O4WOb7pMTJMNJINnYOKZ9k7tpBRr1cN1w7xjEYLMszVaF0s3VjDeW+MUiGPdbKjhs7NRsHBsTS0J8zCyF5oF0Zygq9yXEVO/Izk72jm9oJohcfGtiacMn4+HclaBMBvhgOvMd4j5fpFtzknEt/OnD5NqC406dnZxIQZ6ipFnjA58e+gGtxQhGBWkQATlgI1zmdOybo1OFoj53v5OlN/uhW/eEn9Yr5Th9DdcwxK7TmWMU70kq6EvgB0Vjo7MKsMQ76GmmJXc3fdiejSRM+rIilscYla80JCaPNbhgCs+F1kurmRWWX9VSzOMLTXLK96lDne+OdNNyCnbToh0iKqu+g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ShG0+c4MDHq+TRPNf5eEa1rv01x+5V6MlUVDyX2imoOn0xrn+4Th8BqN0UKtK4BbI6QUqJ8Avd52EJxgPvZaIuIrTy/DDPLWPWQMJUjbZ1cj2LDvZWX0sbFqt1Ks/rEmVH+V3wWaha+t9T2urvMHrh51+DNkjvK7Ru6qpnJ3mRRmQTwbyr7RnGsLOFgcvOiz2qrPjjd9k6pYlM1PmYsCJWIikjG4HooMd09GTq6oEFmrurQLYPgnmlNM4HVGoijN0WQf4I9HkMhbB1b52VEtsIkXlu7rzK/mNCrWSVqm9vyrPLIn09qJcS6AcdOCrqnTaM6hsi5V8CMlm3tvVkgO1w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 19 Sep 2022 13:34:13 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17.09.2022 04:51, Marek Marczykowski-Górecki wrote:
> This is integration of https://github.com/connojd/xue into mainline Xen.
> This patch series includes several patches that I made in the process, some 
> are
> very loosely related.
> 
> The driver developed by Connor supports console via USB3 debug capability. The
> capability is designed to operate mostly independently of normal XHCI driver,
> so this patch series allows dom0 to drive standard USB3 controller part, while
> Xen uses DbC for console output.
>[...] 
> Marek Marczykowski-Górecki (11):
>   drivers/char: allow using both dbgp=xhci and dbgp=ehci
>   IOMMU: add common API for device reserved memory
>   IOMMU/AMD: wire common device reserved memory API
>   drivers/char: mark DMA buffers as reserved for the XHCI
>   drivers/char: add RX support to the XHCI driver
>   drivers/char: fix handling cable re-plug in XHCI console driver
>   drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC
>   IOMMU/VT-d: wire common device reserved memory API
>   console: support multiple serial console simultaneously
>   drivers/char: suspend handling in XHCI console driver
>   drivers/char: add console=ehci as an alias for console=dbgp

Henry,

this series is kind of on the edge between a feature submission and
corrections to existing code, as the base patch introducing the new
driver was merged only recently, and at least some of the things here
aren't clearly "bug" fixes. Additionally it's on the side of larger
ones considering the point in time.

To summarize state: Patches 2-7 are ready to be committed, and Marek
tells me that they're independent of patch 1 (except for a context
conflict). Patch 11 probably also falls in this category. Patch 10,
otoh, is pretty likely to be viewed as a new feature, and hence
likely wants postponing. In any event - if I was to commit any of
these, this couldn't happen earlier than next Monday, as the laptop
I'm currently working with is not (yet) set up to do commits from.

Do you have any particular opinion on the disposition of this series?

Thanks, Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.