Re: [ImageBuilder 0/2] Use lopper to generate partial dts

[Michal Orzel <michal.orzel@xxxxxxx>]

Hi Ayan,

On 12/09/2022 18:27, Ayan Kumar Halder wrote:
> Hi Michal,
> 
> On 12/09/2022 12:59, Michal Orzel wrote:
>> This patch series introduces support to generate automatically passthrough
>> device trees using lopper. This feature should be used with care as the
>> corresponding lopper changes are still in an early support state. Current
>> integration has been tested with several devices from ZynqMP ZCU102 board
>> e.g. serial, spi, ahci, mmc.
>>
>> When using this feature, make sure to use the latest lopper's master branch
>> status [1].
> 
> I am guessing that this is the first time the imagebuilder is using 
> script from an external repo. There might always be a possibility that 
> future changes to lopper (master branch) might not be backward 
> compatible or might break something in imagebuilder.
> 
> As such, will it make things better if lopper is included as a 
> gitsubmodule for imagebuilder. This way a specific revision of lopper 
> will be in sync with a specific revision of imagebuilder.
> 
> Please let me know your thoughts.
> 
I think it could be beneficial in the future but not in the current state.
The reason why is that the lopper changes are in an early support state
(I try to highlight it on each occasion). This means that in the near
future we will be improving lopper extract assists to cover some corner cases.
Adding lopper as a submodule now, would result in a need of additional commits
for the ImageBuilder fetching new lopper changes each time we improve something
in lopper. I think we do not need such overhead at this stage.

Also lopper's README states that "Internal interfaces are subject to change"
so we can assume that the interface given to the user will not change.

> - Ayan
> 
>>
>> [1] https://github.com/devicetree-org/lopper
>>
>> Michal Orzel (2):
>>    Refactor sanity_check_partial_dts
>>    Add support for lopper to generate partial dts
>>
>>   README.md                | 22 ++++++++++--
>>   scripts/common           | 73 +++++++++++++++++++++++++++++-----------
>>   scripts/uboot-script-gen | 17 ++++++++--
>>   3 files changed, 88 insertions(+), 24 deletions(-)
>>

~Michal