[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 13 Sep 2022 13:00:04 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PrzBEVkX0OaF0KQ2cVhHaFzJfpyPpHhSb86Lhl4Vsks=; b=EKlMqsTW1LW3zg+6uaefnyC+CkU9IRiem9IpV5xtKuRDms1Iq8qn0E3TdSh/RDY9YIqUugxc17tFEvlBIFDd+Yspd6hd5yepyZQag2DR8HvS9MzHu8abPsnQQfk1sLi2wHwShyIjOPKXyPi7kKCA3o6iLOEiFkpy2o9yxxmzmO355FQfE/m6XcComAASwGulU8ir3QKUuoMYWKtqoonUfBiW0v+hYyGdn4ICKkIJW7qwAlwYH6G1FeCq/EtCspmJNUeZZcqQFUBJmZK2H2hiOVe9n++5fRn52LGpiXJt7Hplk/yufNohwx6bqb3dQpmFXuEh9TZxHwSophYuMVadgA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TlzvIfq7newQaLz8ml1oTmIgaK4h/rF8MSXE7VY9ahcqAY4MjShLVJAcISRb2zLdIdqTbnx1JnbBf31IkZOw8GE6sRoisKJk9s0sBJxl8NK5thEkFajh0t4J0t80yxJxps6e6/ahhWW+eOI7r13qcoYpuo5+KXuif/ccMK0IuK1s2Ks2bw5XQ2tqLo4JzJpqdV8RdGMphvR28O88Yoxb1oCfsf4bA+arsdf2v+TBozGTF0WOd210Hv/9qWcbEpGC9VgzFf2waDaeFVEjt0EgyeIf/r2lla/07KxI0gXCy95MyyJYmK2llIhdGRMjOykYo3WMaEdMteDUIxJm4sQTSA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Community Manager <community.manager@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 13 Sep 2022 11:00:18 +0000
- Ironport-data: A9a23:l9wbo6sE4VmgbMNhi+HjKxUGvefnOphVZvhN+MifNr3fj3mxXxfKvwFeecGOWvrvwR7zc1ddt3lPhdgZHeZvr8pSu/FqY+x+PcERelX8FoNJjALt4IUTleeGmZqm9GQuKgvmoC0JQ8Cuu2ojDyknEuM+KbNN9LyubXXFbD23S7m37+HUClbALuZ7b82mV4e0BRXoGip1egK1f0Rw44G+F4+gaXyBRs/KkQUsKvtEpZKB83RpbdtendRD0VAaiJPEWk+3stDjI5jZRmG8Cm2+2pBnPUa+CWyaVOHpf7B+1KUlbO7k16ko2pb/R97gZdQXnSCXVdCvmmEsz1B+nuAuNVHW84nPd/QgQG/yrGjffgUb4B2Dd/Zk+pEfkrr5c7KQzHgEaPHtQ9IE69C5CMaqvFuNgbFGWaj3ab7ha1WHdZ30d7KcE25sOfngfxzWbutjJaHeUzQclxCOLJlwfrQjCY1/7z4zTdmS1hwGDAzjjyNFcmEqdR+NOOyoCV37XnWO3Y5vyBOTKm59/JIDDNtRubbR7HKFHnIKUw4xX3JohiS2LQI6xnFZPoKuqPBBlAyVSq9eY0xMO8sf22a8g0EjClVUuor0CRwN7ByqZDQ8rRKJZVUixm+jZ5hGv61cGGkL+tmwk5qPEs/DnPHgNcKOGKGjKSO58P7Qygnm8L6zuuGJwzNO6389WdX9zGsrFUvi3syrdgN4cZp1UCm/zHnW4CekCKnHktX3i32G+djqxHT4PBy2NfkQ+IuK1hFC2RZzI5LMPCGH5WBk9Ox7FJJPK2R164ATki4YRReEnc5vu+zDb99a9Onf4Gjq3/7JvXG1kikv+WwqEqgn8u4AwcWm3j+PXJfxLU6I+npjmpcZ2/U4FD9llv9yoBl0+q2HOLN1Y1Th3blJ7xO3BzEVVaXk8QiVKYHiWzz5pYVt3utlsxMlmobuP/XyM+MBnE4R7NdTW9g4bXTjsDW7dWD/6Chr2n51Jr6UiSGc4V0pVmEvbBV/FymisbX6zky9X6YwUB+EG7divAL4Uj0FyYCm8i36Ms4Cnh92Y3FhBU9zUZtMdDT9GkithzF9LTrg/re7oWXXOyyPgQaGre/R1MfN+PZrjMiC9lxkaxIkQoETGzW3D+eV5i4L+k9fWE52LWPL81mQHEMVBdXAWRi5pTW/zlNLiSiDVQZe+brlXuwow36ho2LzENmVVesCituDvoGfE7OFwHw8MZDIYHQgxZKXp7ygkOmaW7vKmVAYA6JqMV+DqFGPwG53aX0/1J5S4sfft8u/PtR9ilB5gNAe9UGi87XwfidskSyUPxiP/qsP56jHlxGGj7sCXCNFFJGgAFknLBdXTNB+NeNac7Anrj0VOs7juA16weGg+bCYaoYuJZiaqIbP2N4R38jaXzBc/n7Dm5DefxvDYO6K7C3xk+Jq8qfLzHUY9GGlIwAol0VRgWEXyaF2YzWdUU9TFCF52Z4Fm+b4HdPtaliFeVk8XlnI+ATKxcqIF8a5qYYzg4qwCx10A4jMVSDWZGoENfJ4z2BKVscJPMk4paquxl9jld+dor6ayGORpJQtFkHbCOa1CUNRFmyNkfUMVQjTixEFjYZoQ66VARya5wv25x70+dlNXatmbr0r3LY1AEgQhicWJWCzupQUMYaoGcUeVO8KUyYNgmi+k4lDJVP3s03ESfaUFv1QYnDKTlQwX6YMmsjH4Ab3uhfE8v6m+9uXVTxJpI2/sF2UwuI0bJAAc4q6rbTnnMgAb5IG8pDflptFe/dyrMIc+8/+4YkL91eN7P7cfQFfDvh4wMplyiqqUkVymB13DigM6kfwHFp+CMPEqciHurT75fmN+RGaAI06VlXyUzBKtf7CU9qc7i14DnllQ6o9sp4GgKw/nuIUrvrEYZaj4y28b9Hgz3d5y3cyvO7g9yjbLKpIlvulh4/HabPIfIOFA+bYLa88Fa2Kxq/N6wQQsouIzTi9WCuzfA9UvHygR+N3VQocsxf9NA2Xluspiu0f6rYLBLEFGw7LnrmVthmRmd6wzu5z2rrqjyckfziiLE7HqdZv7Pylco87BALzn154FZXK/EJNdLNxufppeiDKHWQ/RzuPpthjOsAWU1K8G4d2QkJIkmBLPJVl6JI4hMaBKB3Wri+L1bocA6tq94GkYyacs8qqD+8zrUfi88G5SvdcQwV4Bzci9A8t77AahU+kfZJGAu7xs0PTE1Y0S2QIzMpuewkODQc9ELCKd7IdsAH5JMQ49RCQaUjbsT8q5r9Xr067zwVxNFLOR1UJ61LBKYVTtnLbPASetS02reuNFZXVadT0zV4cBAjeNO6gjQCDBRpggcQ9VkiEU8XIyOi0WlyugDJYMGYvfDMVqFIMLkx3AwQY+cfTo68ffz4wJbCX0nUylvZAsW4gcYdTCPYTh08Bvckua1nd7JJWLd0ow2OeZDWINbSg+0uNnDQmjWb5W98WO6n5SSAXWVDsxcVlavpXXVL5UXGfeQd+PX1GA6ZOJwFs+QLzq/b5UbIxZ3zZqg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Aug 15, 2022 at 06:49:08PM +0000, Andrew Cooper wrote:
> On 15/08/2022 10:14, Jan Beulich wrote:
> > On 15.08.2022 10:15, Andrew Cooper wrote:
> >> On 15/08/2022 09:01, Jan Beulich wrote:
> >>> On 17.05.2022 17:31, Roger Pau Monne wrote:
> >>>> Roger Pau Monne (3):
> >>>> amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL
> >>>> amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests
> >>>> amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD
> >>> I came to realize that I had announced that I would commit this about a
> >>> month ago. I've done so now, but there was quite a bit of re-basing
> >>> necessary, to a fair degree because of this delay that I did introduce
> >>> by oversight. I hope I didn't screw up anywhere.
> >> Revert them, or I will.
> > There is no basis for reverting
>
> You have falsified tags from me, which is a consequence of the series
> not having been reviewed correctly.
Seeing the changes done to the commits, I guess the problem was the
'Suggested-by' tag. This was added by me, and has been there since v1
because it was you who suggested to do this work, and additionally
provided guidance on how the implementation should look like in:
https://lore.kernel.org/xen-devel/4457dcd5-6a64-355a-b794-6b404cf90335@xxxxxxxxxx/
I'm sorry if this turned out to not look like you expected/wanted.
It's possible we had informal conversations about this where we
discussed changes, but TBH I have quite a big queue of patches, so
it's likely I've forgotten about.
I'm happy to make any further adjustments to the code, but I will need
to be pointed out at issues.
Thanks, Roger.
|
