[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Thu, 8 Sep 2022 12:31:00 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Owx4enNlxYj4A+G5gejC0zzYLiB7DggolNr7gKWjFk=; b=jYZrTGRblzYl0jHfpE//dFko6zkmAb6O5ZTpy+G/ke0EhXRAmH8F8ETmNxGPDH2oUg8OtxG4tfU/NRk1EuO46UqQtlDzrx3zkLYkrtyOeFuySPuNhmevrfoRnAi6BNxCI3woR9LGD/b9Ni/4smoE4XXz1RwBXjIgIf9wIwqPcTZ0i+QjoLaRkOhLI5tzQ0VwTiT9tieIdQVaMXxsJmwouJtUhpdf1To2Wz7dCKeji5AuqkgwVYicTjzgNW93vp0ofx0nTARBUUq+OovxYqNr1RkLb14rfFs3ANcSIix5L1j63qI4Ckm3y5xOqDetPTpNs+Rn8/k1XobPHFZeWy8LJA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Owx4enNlxYj4A+G5gejC0zzYLiB7DggolNr7gKWjFk=; b=JD77nypOy4m+/GZ1YUa30l+f44fdk24NuNmD7WT3JKwak7zu88T9s8f0y9uyIhhP0mnwzvKcl8e3Hl/82cx9XiKXJa9+7bW5ORY7Jn3EMDa+BAeuaLKf4ez14fBMmFzODt6ytb5xPDYDMl/5fWVc5eMTRhQZJmvLxantCAcGbgrOwcmvFNHtlnSByHWnolrjELX6yskFFtFOD2o8G76blBWYIwH0InSuda8dVCyDLGIc+eu30UJNiM/6dm3EPtejg81SaK2Kx/sunCg/6KKUQ4zrB2vTUBEAPQjxZ3urlvvQYryD/LGAjxx04/cQvqPxUKoW6NVhfp0O9VMW9s5Dbg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=N093/A0HRDQ5tFpDHB/y8u/1zPyGom06yea45BteORrt0tO1FwVxi/nycoEgyUJ8+G62rT1wwlQDvllwyXI9FV006RTkHKucC8VqaK1I+8KaJqsrhjPEuEU8ZQFK303C3yas/IZi0qN8Ji/6AMZRYKnPqM4wbRqiOHTiGK4zd53TYLNJ4UOeZzYlL/VPKJQzNwGO9e9+SY6ylU85FDvRBVu0WZAlDisaBsrekfc1hCA4pnBDjNKsIWX5TfQfbNCjnmhMqd/TFfIZYoATsN5rOr/kmiR4ZesGBSafWw462V3QH28tI2KBoLalgANb/exooJ0CpwJqeiVuD5rUTFuiEw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IfAoX59IHOhN6AO+RmQvb/EthpGOugoiPnHrciot7hA/86xYI3LHDhgG7AAo7dee2SRGQKnudaJZrrWDx9mHLKDdepkfk74TEFecAK3bj1ITrIG8d2YiDNmTJAQhz7fxjs05zK/HC3COHKn4+djmDeQtdIUgTnr+uWEu76nmQU51+75Kv2fDs4gT5anRoNdIC9T1AR+NfOjSka+i5RvMgdNpO5eQYfMRli8B/zZIk9Vdxa4ilyrcMj9yADKxm9gWSU9vWALyYg8ZIiXb6fWoDXX+eH0kAhrNyXERkXBcB/WJSYgyP5EjRzC4CX7oVs+xwhd6SV4A3IOx0uEKEMIWSg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 08 Sep 2022 12:31:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYw3p7gwIvcD2fwEqa0fZdexa62K3Vbv8AgAAHwAA=
- Thread-topic: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar
Hi Jan,
> On 8 Sep 2022, at 1:03 pm, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 08.09.2022 13:49, Rahul Singh wrote:
>> is_memory_hole was implemented for x86 and not for ARM when introduced.
>> Replace is_memory_hole call to pci_check_bar as function should check
>> if device BAR is in defined memory range. Also, add an implementation
>> for ARM which is required for PCI passthrough.
>>
>> On x86, pci_check_bar will call is_memory_hole which will check if BAR
>> is not overlapping with any memory region defined in the memory map.
>>
>> On ARM, pci_check_bar will go through the host bridge ranges and check
>> if the BAR is in the range of defined ranges.
>>
>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> # x86, common
>
> FTAOD: I object to this tagging, and I did not provide the ack with
> such tags. Quoting docs/process/sending-patches.pandoc: "The
> `Acked-by:` tag can only be given by a **maintainer** of the modified
> code, and it only covers the code the maintainer is responsible for."
> The doc provides for tagging here, yes, but such should only be used
> for the unusual case of an ack restricted to less than what a
> person's maintainership covers. Otherwise we'd end up seeing overly
> many tagged acks. (Recall that tagged R-b is also expected to be the
> exception, not the common case.)
>
Ok. I will remove “# x86, common” if I get comments on this patch
and there is a need for the the next version, otherwise, I suggest
that the committer can remove this while committing the patch.
Regards,
Rahul
|
