[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar
- To: Rahul Singh <rahul.singh@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 8 Sep 2022 14:03:16 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ls0tyWDGIiSaXCFVTZ2tvhL+UWOC5u+M/W4tE96CDQk=; b=irv1/f3RKQ8mJOCtdNHuarbWDfzqf2UaBrS6W58xAPSOcbVyOoB55/2932Yw2FOv81/swoFj4/25805XKIYUkUFTLQK7XyMkb9UZczVxeobgky+hs9b7zFSyfCf33VR3SzV8iyQEZJj75qghnLWwMc2pFnv4YFbXqDS4Ad6kHqi6BhF0xqXg+tDYSbLRk4EvNDnlWtBTNAM6xvm2Zv6JeoYDMBaPX6hQKZJICJyFd/VJSlHKWP1hcI8wMgZWiIq91N5BpLTtDD9au20U/3CJk5hlpNO1ycSwwUaHcfm+Vvpj6V7SXCxluw9g+NgV6g8VY7OMQ4sU2GNezYBRaUdA1g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IET+Yr8IXtBSmpo9TzcsnvHtcKdPcGkZ4PHKR1zwB8ZvbJf5Xx8gp1y99i0mgzJIDoZZv5cafBINH58AYKWXOVTxFu9ElZ/JZEAIrpcgg8hYC0suKd2A9+nLpYLyoPYnZ1m5HZA3UYQE6SUaM0EtdGbPyvZA132v2FUW6gJAwiHW+d6NRPYREgL6Eq/R5bI/9t2Twwacv96PbOqdrORbv3qOkmCBKccqWJkMfvm96Fp7JGmZgHgHS/8WNL516jcImHAo6bvItOBDf2zS1EmIpAUZ7Fl1AVcBlVxaeZCKSOJkWlzcmYIeIRneO9lFeHu8eXTYdCc4lz8B3t7hTXiJ9Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 08 Sep 2022 12:03:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.09.2022 13:49, Rahul Singh wrote:
> is_memory_hole was implemented for x86 and not for ARM when introduced.
> Replace is_memory_hole call to pci_check_bar as function should check
> if device BAR is in defined memory range. Also, add an implementation
> for ARM which is required for PCI passthrough.
>
> On x86, pci_check_bar will call is_memory_hole which will check if BAR
> is not overlapping with any memory region defined in the memory map.
>
> On ARM, pci_check_bar will go through the host bridge ranges and check
> if the BAR is in the range of defined ranges.
>
> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> # x86, common
FTAOD: I object to this tagging, and I did not provide the ack with
such tags. Quoting docs/process/sending-patches.pandoc: "The
`Acked-by:` tag can only be given by a **maintainer** of the modified
code, and it only covers the code the maintainer is responsible for."
The doc provides for tagging here, yes, but such should only be used
for the unusual case of an ack restricted to less than what a
person's maintainership covers. Otherwise we'd end up seeing overly
many tagged acks. (Recall that tagged R-b is also expected to be the
exception, not the common case.)
Jan
|
