[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 10/10] drivers/char: use smp barriers in xhci driver


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 6 Sep 2022 11:23:38 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=57/bYk9q+8WaTm2K+86JZhQVBKn50AlbT9LrSB7MjhA=; b=ahdW7lEI/MivnvHD2rEZPi7nKQEVm3SgudmSocf+JkHuDusF+GYUuV+q3zpOeG4IFPln1ZuruSZNQekMWHWJ+BKazWCFibVtfFjRQupxoEH2iztmxhl/tbueRCSEKHJINKhgqWBvDHE2qG0VEQnXCdyA+mFkFX/KOqcT2WTfTOMB0HIlHKQ4NVFYUxlkocqz2MbYO519NIqJ15hfRvqTkgt6AQu7p2ByvZgiUVsXkjcB/0Eo9OoEVlniFqWIGiPyMgSMlXGEyTBy6Y24ZrTTuWdUwHWybbuZV9d1N/zfddbaCP1bsddf7bfQZR7ebvFI2ROzQ94CyFMpOT8ndBrzBg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gFWbR77luFoFB1moDkvx7RG2MTpRoXKQOpfXG5kdNppOF6fOw/nQGeKQub0L5fJ1ick1JsyfwR7uNJpDr4mnxNTkyz9vp32bxOHTwyGLCdI3kbP3IsOoJNodKvjTwytsCJXaZV4Hz6FCX4fJfrdDRFZ9I/dFW2GqQJ2x/Fr9dkWOByqcVM9SurrLsMYtfZVhESggGw2WiTlkZhzpKl8DxrjkJ3vQcBJzNaXLoyzBOLYtk2sGgrDonYLugPr7xGa6KEmJrOYSXRIQh0IUDMmMmxD5lqUJTZvkknCUy+YF/daqCCrrmtjD+dAEmIqDNkDXg+dyuLpaU+L/fIZiJh60KQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 06 Sep 2022 21:39:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 02.09.2022 15:17, Marek Marczykowski-Górecki wrote:
> All (interesting) data is in plain WB cached memory, and the few BAR
> register that are configured have a UC mapping, which orders properly
> WRT other writes on x86.
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

As said in reply to Andrew's comment: What about non-x86? Drivers like
this one, even if presently depending on X86 in Kconfig, shouldn't be
making assumptions like this. Such is imo only appropriate when a
driver conceivably would only ever be useful on x86.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.