[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 6/6] xen: introduce a Kconfig option to configure NUMA nodes number
- To: Wei Chen <Wei.Chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 6 Sep 2022 09:12:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Qv1yRbwFt54gt5dYwQMtYOC2jFf4S9KVBq4/ZC3nuI=; b=QXHsq3myEofUV4I/2I+72yqCfE32c8Q4t6cSDHWWo88wFFScOubFs0KSwHBIq8DBINvMc9dZSWr7XN4Lu4Q+2n83/RywCJ/KwMKkPO74b0rJypmcipZGguF13jne1etqpfCLIQZl+QMYcp0ZuklLWBl+BcEFAJltQxfmseNLWmuDtow1U2MgJ9C5SE8+rKZ4sqRCWFzUZKsLHGdamHCbQ5h6pTzjPR3+3hVDCiJCoz74lu219PQwJcNRi+jTYoSM/ThBV3jLlrpj12zzyyo47Ctk9i2pw0Fq+VpyoHd0HZPmDkM8ABLXD2AHDvqaNWYMZTDZZu5yl7jNkZP9k53zog==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CRomu4KIra23FRvt8ImYMMDtzoTUsT4O2cXbWR9BaKjIBzqnRcLLxSpSOy8+vGxoelFnuH+bKgr8VBUgLhMuYeZPp8ZhULqa51PmL12g5Q+JWk5sEeGH9BIkgs2sh9G2ysXc/k3A6WAJiugD98Gv+zDhyYUPZH1HAYqND78C+Wd6ulynlMliGEKQWEQP96qWsS+/P7M9p8K7npq1/WkCiFK20btud/HYJoSaXwY4otN3nfReIj1dL+6b4MK/ZeYrQNLASeLaKPHutLLscVZLSxq34cdCjM8obgweDvB/uwfW0B36Y90L6i0OhcuYHpFaR7b2fbihnT+pM0RDepeusw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Sep 2022 07:12:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.08.2022 13:00, Wei Chen wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2022年8月25日 21:06
>>
>> Note that there's an alternative with less #ifdef-ary:
>>
>> config NR_NUMA_NODES
>> int "Maximum number of NUMA nodes supported" if NUMA
>> range 2 64 if NUMA
>> default "1" if !NUMA
>> default "64"
>>
>> But I can see reasons why one might deem it better for there to
>> not be any CONFIG_NR_NUMA_NODES in the resulting .config when
>> !NUMA.
>>
>
> Is it because there are many places where alternative patches need to
> be added for #ifndef CONFIG_NR_NUMA_NODES?
Well, yes - that's why I said "with less #ifdef-ary". As you may have
noticed, excessive use of #ifdef easily makes code hard to read.
Jan
|
