[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/6] xen/x86: move NUMA scan nodes codes from x86 to common
- To: Wei Chen <Wei.Chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 6 Sep 2022 09:10:08 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DsDDV/FN9vy0G1r/S2w2wFWcUVlkivmZdtxVuZRHZZM=; b=mbM+ZcrACjqM8rIHTfCuGf2cCk/GJc2fE+Wqf1KE2K/vuJp09LLeUCfCz5u+AaPDobKIzcG1puJ8+U1uIeTT9Pj7kLscNHKUayK/x6iAQilHe+3Z5lDq9xhAV8cds5wt4d+5VmkffXAF1iMzjgp+MHWkJJ9wo8xQzgqXy/EfSLgouHUNlxNp53VRFxW6CboQbSzFrPuonTabbJTginq9jZ/Z+Unfee66XlHjvtl5iuO/WH9O/ADjMF7e39wDJPa6wyJqeBHLrvo19THkCrXJNoJgfKPGc9C4bsHQcH7jjDYSr3qo1Wl3BkH0urQQUMksqTonk6uO4Mm6e6TAqLvRWQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T+uPVakEg9iCuSZGgaL1kxnntWXlc4Nt1Rooa1M1A2b40qWabWmnLNLYo9Keikef173XNCScxXf3w3xX2vykLF+ZuJ9NQJlnIVB1nwo0Mfq5aWkBboD9yeP6PCRhY2mQpNQ6pcCobuvI/z20ciqbRq+vR4+RBcLqdyOsLZRrk210KJHbwo7fLWav8PelUrm5BstlSz9VURu+dUaXkROnUqErzeWfAo6WZqjmfrTladPtc+G4hgZysw/fhDjlwKpHxtTkShMj26V3/LuelyZC0MvgdUarE/dwfqgKqTLcVsYLTOAQxmBRkogH0RggjBjpK7j6mZnCKKs0Qg/CW1WG2w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Sep 2022 07:10:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.08.2022 12:47, Wei Chen wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2022年8月25日 20:50
>>
>> On 22.08.2022 04:58, Wei Chen wrote:
>>> +bool __init numa_memblks_available(void)
>>> +{
>>> + return num_node_memblks < NR_NODE_MEMBLKS;
>>> +}
>>
>> This is kind of clumsy, but I have no better suggestion.
>>
>
> Did you mean the whole function or just the name?
The need for it (as even a non-inline function) primarily. Its
name at least reflects its purpose, so would be okay-ish.
Jan
|
