[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory
- To: Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 5 Sep 2022 12:10:28 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQNrynW96T7bdfkC1QPh5+rO/TbSBYGFxulXEpZ+MPo=; b=UATG8DC4/DlXMsFyFRMYwBMrn5sHr6RfbqLblgvDnUvzzzi8nYVOh29381Zw7H7tE3pyXRjbAx9jwlvGjLQudbVouZ4NqaEkMOwsJM7c4qmskgOINy6+42IB8893eN3lyI+7wxo0G9OQw5qNR326dXLZ90YeGyA692b0DMFfMYiigURGmmUcWgGY7tDqFJIZAh2l5+W/0/q8WC2wh4nfMzol3zUHZVhhUcdqPcdJvTGtlq9nEyc5PIeGOwoBogS2iunYva9HO+bB+sMaDoU089NtwimK8emuIEyLK0cER4WSxAt4t4cvuIu4pmondRs0BaAAPHjtR4b4DtdcVmctHA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YQNrynW96T7bdfkC1QPh5+rO/TbSBYGFxulXEpZ+MPo=; b=DddbSiBxsqxtYrvgz0Uz3X2ZJgpu6B03uBQzEKehM58tXHsgi8Jqp0CEgxshsCBppdYiUzJU9h8vNw5LyaLrRs2rTaYDPbqm8/PqR/3NthD89Sz22pApHpQUUbaOkv8iGGO5DBPt5Yj7OvCJk5oFXvOhd7dr6iaFHiFs6hyPpN6JlOsx8Meaqe7jIwE4t/57OUqX6OC8rOw+3nt8LXjxTiUWrkxWrR4tuyyfZK7lJ7jNlRNgwYUPa4icCjKYtZ5fieFZgFlEMgYnCbl9yqNj8uABbqP1eP4A5wZpkFYCaT0WVyqmp/lmxx4+FImDELz2rXiVbf2Ok0aRGIZZTU94pQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ixac/NeVPJw7xpDm82UcpVbBkzK0k4JM8eRMloRPsz1pB0kjHt84r/MrGYPMIpJXQw0aPU5Y6VFzEW79M2SE9sJ/Knr6StpXd8W9rnZDpj/EDQXjeNOTEdD4x/6pdicb2twQ/oHfF1oJbUSzmJCn3SQluQsoYJ7A/7dx2+iTXtH7C/CUXYodiWm84yR0oXTHRoOSeyZ9jmtuMOVq0qgmzPdVqdCdyCiSQa3g2k8KUHWLP23wVZz9/to/7HtDvNRBiE2kX7/8yTXM/n34xVX8r/U8HDgG0tW/j6tYlPQdEI2GyOm9G5n4PL4wGkJA/Zokz/+qHcKENYwJSBmL4Ten9g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LWv2BQXCEnWJMaMNf74xC6FADZByo5R3YnvJ/cSGTujSVkJcEP6SKLNx3InVfQ6i+DS9LpGHlx+oCjpq3g0quaqKoOq3LQKdaeezZIYAgBJ4AnCWlJdWLq6EV0MKap8NzLvAircoAY0SmsarcFkXd0M2xZwa/e4NNVq1IVudd0BKpAwbtSXiogM1RjDXZ/JL+7LHASgCOCYWeFkKeMVYCDQTwwGqSdr4glCMPtZ/+mDZFZRm8ZWjIT+AOCX1aI/8F597IQbF4y5LD9LQtTNshIwCwgq7YnyCXlFAdATuGEAGWrdI/mlLxiwXeTcER1YevZzdmgTXTlqoLLrYa5TDMA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
- Delivery-date: Mon, 05 Sep 2022 12:10:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYwPjzoXW29+zrjEaaAKDaLd6E0a3QvVUAgAAAVfA=
- Thread-topic: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory
Hi Michal,
> -----Original Message-----
> From: Michal Orzel <michal.orzel@xxxxxxx>
> > +typedef enum {
> > + MEMBANK_MEMORY,
> > + MEMBANK_XEN_DOMAIN, /* whether the memory bank is bound to a
> Xen domain. */
> > + MEMBANK_RSVD_HEAP, /* whether the memory bank is reserved as
> heap. */
> > +} membank_type;
> Whereas the patch itself looks ok (it must be modified anyway given the
> comments for patch #2),
> MEMBANK_XEN_DOMAIN name is quite ambiguous to me, now when it is
> part of membank_type enum.
> Something like MEMBANK_STATIC or MEMBANK_STATICMEM would be
> much cleaner in my opinion
> as it would directly indicate what type of memory we are talking about.
Thanks for the suggestion. I am pretty bad in naming things so in this patch
I simply reused the original name for static memory banks.
I prefer MEMBANK_STATICMEM and will change in v3. I will check the
80 char limit in current code, if STATICMEM does not fit, I will go STATIC.
Kind regards,
Henry
>
> ~Michal
|
