[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory
- To: Henry Wang <Henry.Wang@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Mon, 5 Sep 2022 14:04:24 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yj8RwooBFay5ImDaoLqnb0VynjqAuZ3CV+5rX8NPc20=; b=IEWpMgUE087DRTqZg+7sF/0G5K/sP2hQFn+bQlnHLqmUCThI/GeFAeU3jryiVRqz4nCkwWTLQzvupRo4M8ZFq9D/kcdB0pe1LyhLWvf0JTZG/VJHZDuneCZn0M4U40CofLYQSySixcXqbeLTMUbxEau9C04eDz9yU4u888VRiATA7YQYyd0j2/4/ZQ6txbsWXkgagrzy/HALgbFUlarh+qf0WLFG2L/EYgxV0A8dD39jUUsYuj0B6rOfo5D2nqeW+oJkgDbVZ1pynF8KtJkEZ2emI2Qw7ewtAmxPmfy+WnPMpNmTzyBjVkGcwGP+nTlPH5A5SNL5h/j40aLpfVVbAA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rp+s7wyMNPsptLieyDaBq3W20FfRw0AD6c0ouJpxI6+GQhnID4u9vK/8MYTrg50ZcJUdLJVZahirVzUElLoVuZ2eZY3WShMkLuZsbNpgoIKRw0nGjzvCfzUxyg3ziWj7sVllMqU2F4AXkJ5jP+6nORaL+5gZqIfoPU+lz5bEcuXSiF+ZUEyw7u95BonIhCYpQRbnGJJ1bf7gewDCoiVjFJbu+uCFRvyF+0IRHyxaDHtaFHrL/u3RrS+9ct3EdzEd1D4IcLdfolNhtScC5sAh8VcmmGWIiw+4f9a8Ce62PMbZT33iypKb1605Fqa6Ch3UFhb0LJKz5TmG9F6d5wKrmQ==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Wei Chen <wei.chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "Penny Zheng" <penny.zheng@xxxxxxx>
- Delivery-date: Mon, 05 Sep 2022 12:04:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Henry,
On 05/09/2022 09:26, Henry Wang wrote:
>
> diff --git a/xen/arch/arm/include/asm/setup.h
> b/xen/arch/arm/include/asm/setup.h
> index 5815ccf8c5..d0cc556833 100644
> --- a/xen/arch/arm/include/asm/setup.h
> +++ b/xen/arch/arm/include/asm/setup.h
> @@ -22,11 +22,16 @@ typedef enum {
> BOOTMOD_UNKNOWN
> } bootmodule_kind;
>
> +typedef enum {
> + MEMBANK_MEMORY,
> + MEMBANK_XEN_DOMAIN, /* whether the memory bank is bound to a Xen domain.
> */
> + MEMBANK_RSVD_HEAP, /* whether the memory bank is reserved as heap. */
> +} membank_type;
Whereas the patch itself looks ok (it must be modified anyway given the
comments for patch #2),
MEMBANK_XEN_DOMAIN name is quite ambiguous to me, now when it is part of
membank_type enum.
Something like MEMBANK_STATIC or MEMBANK_STATICMEM would be much cleaner in my
opinion
as it would directly indicate what type of memory we are talking about.
~Michal
|
