Re: [PATCH v3 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()

[Juergen Gross <jgross@xxxxxxxx>]

On 01.09.22 13:17, Andrew Cooper wrote:
> On 16/08/2022 11:13, Juergen Gross wrote:
> > diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> > index f6eed88930..228470ac41 100644
> > --- a/xen/common/sched/core.c
> > +++ b/xen/common/sched/core.c
> > @@ -3237,6 +3237,75 @@ out:
> >       return ret;
> >   }
> >   
> > +/*
> > + * Allocate all memory needed for schedule_cpu_rm_free(), which can't do that
> > + * due to be called in stop_machine() context with interrupts disabled.
> As a minor observation, this is awkward grammar.  I'd suggest "...
> needed for free_cpu_rm_data(), as allocations cannot be made in
> stop_machine() context".
Okay, will change it.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature