[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()
- To: Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 1 Sep 2022 11:17:02 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1XeAqMZOQn8rtmQbiOmOwn6tHWrlcUZaXrWPVJfxQso=; b=Ch+VGjZLf3npPrNJLepsxzoVf0sZKIIhI/aUZVdOBhphSXS+bFykY9jb143+ya7ikgIzwtOHtgDZRu+tx7dAgUnAQuo9cGkWmbm+ZZyZNDbKVJWy/uPwg2U8i2PdUH4pPIfFD4LXGuRz5gCtatQQs6G5ED4x8aUB2vQDYi0FNm2C60jZHUut7hPN1YgiR0LtaBUlCZcMAriiI1eAKVVeQtphHtbBI/EIkOUmDmehKSk1wUGFGyUJgUnrhTfwYdPonlkxYB2eJUrbMkvzPNyZ6QBgJu7kzYzbhAFUIb7vDvS4ktSK7MiGDjz5FWixn+ZHwIaUxl/O99dxeZzNCp4WQw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hrBhQ5o417KMBLU2me2mhEG1ne2tKKGfH/tMqj+eMnMOEvWEB2mriuvezjRoAKviCyYjDYKrVuosvtvwK5u8K/vPYVGeqTIroa48J+fJN/ymLMJnsDgn6Kqx6kW10fyGeOwTLHacl6vzfGdeZBKXIgWkZVeB/tkkgxZqny85u5ToTLWRFw9B81rSU+A91ClhF59Zlv8YK7gF1AOJfqsMmQh3y8GUBk53TVsuyKyMoSWUM/+oBH3Dxpyd1CK4Lv2TzFWp1aq1u6DssjtAscmiftZ4AS19xmXM006OAcB+KDU6BwJWncCegouMSlIbSYG9G9oGIh5A42mO/2lFCUIznA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>
- Delivery-date: Thu, 01 Sep 2022 11:17:18 +0000
- Ironport-data: A9a23:ScAj/qt11Wc6c3I1Tb/LOJjEn+fnVHFfMUV32f8akzHdYApBsoF/q tZmKTuPPfiDY2DwLdlyaojg80JV7MDcyIJhSQNkrS9gHi5A+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4GpA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FYwx+bxQMHhyz sw3GjExTAivjv+Uwb3uH4GAhux7RCXqFKU2nyg4iB38U7MhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9QLT/PJqi4TQ5FUZPLzFGdzZYNGVA+5SmV6Vv Dnu9GXlGBAKcteYzFJp91rz17KTwnilBOr+EpXj691B0HKw21YcJxhKVAeVgeKBkEuhDoc3x 0s8v3BGQbIJ3E6kVN7mRDWjvWWJ+BUbXrJ4A+A8rQ2A1KfQywKYHXQfCC5MbsQ8s807TiBs0 UWG9/vlCzVgv7ySTXO17aqPoHW5Pi19EIMZTSoNTA9A79y9pog210rLVow6SPPzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKzASpoRGpBcmS8g Q==
- Ironport-hdrordr: A9a23:cqR5dqMhuEvU6sBcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw6zvmWehTNYd3E8LAs27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYsVjU6cwqlcc3IUyYiKoWS8gK1a3KhgKA
- Thread-topic: [PATCH v3 2/3] xen/sched: carve out memory allocation and freeing from schedule_cpu_rm()
On 16/08/2022 11:13, Juergen Gross wrote:
> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c
> index f6eed88930..228470ac41 100644
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -3237,6 +3237,75 @@ out:
> return ret;
> }
>
> +/*
> + * Allocate all memory needed for schedule_cpu_rm_free(), which can't do that
> + * due to be called in stop_machine() context with interrupts disabled.
As a minor observation, this is awkward grammar. I'd suggest "...
needed for free_cpu_rm_data(), as allocations cannot be made in
stop_machine() context".
~Andrew
|
