Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

[Xenia Ragiadakou <burzalodowa@xxxxxxxxx>]

On 7/29/22 16:41, Bertrand Marquis wrote:
> Hi Xenia,
>
> > On 29 Jul 2022, at 07:31, Xenia Ragiadakou <burzalodowa@xxxxxxxxx> wrote:
> >
> > Hi Jan,
> >
> > On 7/29/22 09:26, Jan Beulich wrote:
> > > On 28.07.2022 18:21, Xenia Ragiadakou wrote:
> > > > --- a/xen/arch/arm/domain.c
> > > > +++ b/xen/arch/arm/domain.c
> > > > @@ -63,7 +63,7 @@ static void do_idle(void)
> > > >       rcu_idle_exit(cpu);
> > > >   }
> > > >   -void idle_loop(void)
> > > > +static void idle_loop(void)
> > > While you're adding "noreturn" below, shouldn't this one be marked so
> > > as well? Preferably with the addition:
> > > Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Yes, but I was not sure if this should go in this patch or in a separate one.
> As you modify the function to make it static, I think it is ok to also add the 
> noreturn in the same patch.
>
> With that done, you can add my:
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>
> Cheers
> Bertrand
I consider this change unrelated to the patch. I think it is a bad 
practice to squash unrelated changes in a single patch. Also, I do not 
think it is unfair to be obliged to make it in order for the patch to be 
accepted.
I could have taken the opportunity to fix this in the same patch but I 
decided to not take it.
--
Xenia