[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation



Hi Jan,

On 7/29/22 09:26, Jan Beulich wrote:
On 28.07.2022 18:21, Xenia Ragiadakou wrote:
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -63,7 +63,7 @@ static void do_idle(void)
      rcu_idle_exit(cpu);
  }
-void idle_loop(void)
+static void idle_loop(void)

While you're adding "noreturn" below, shouldn't this one be marked so
as well? Preferably with the addition:
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>


Yes, but I was not sure if this should go in this patch or in a separate one.

--
Xenia



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.