Re: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings()

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 18/07/2022 09:47, Jan Beulich wrote:
> On 16.07.2022 16:38, Julien Grall wrote:
> > On 04/07/2022 13:35, Bertrand Marquis wrote:
> > > > On 24 Jun 2022, at 10:11, Julien Grall <julien@xxxxxxx> wrote:
> > > >
> > > > From: Julien Grall <jgrall@xxxxxxxxxx>
> > > >
> > > > Both destroy_xen_mappings() and modify_xen_mappings() will take in
> > > > parameter a range [start, end[. Both end should be page aligned.
> > > >
> > > > Add extra ASSERT() to ensure start and end are page aligned. Take the
> > > > opportunity to rename 'v' to 's' to be consistent with the other helper.
> > > >
> > > > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> > > With the prototype updated in mm.h as suggested by Michal:
> > Done. I will send a new version shortly.
> I notice you had applied and then reverted this, with the revert saying
> an x86 ack was missing. I don't see any need for an x86 ack here though,
> so I'm puzzled ...
Sorry, I am not sure why I thought this needed an x86 ack. I will 
(re-)commit it shortly.
Cheers,

--
Julien Grall