[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Fri, 15 Jul 2022 07:18:17 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=arymSuFwklfPLOmYlNy8bZY5qdA7XbUIlSc8COvUre8=; b=YKFXhFXplSk1v4hoPptt6lk6B9lUFSDqZbuAu/crDIIzBQ4slrp8n1s10fwzlUqreu71AaxUS4DdHI8CAXQ3fz39nZLtyoUFVSH+SebG2ZGWWsPLS6gcQpVxRPisLeWK8utkLbuUX/F6Q+K1NovhgYskLeEl51pLrd2BEBlPAyB3+EZTJEs7jCNa52/HrUdF4oRsgyGc5wDkLV0JZRe6Ug9hg/39VJ4iEThKNaE7PFLBmOiu1tqIY3ix0+44Qw+2mzQiPZ2m8XrBAzK5fG9GtXwl1YWcf+CtxrKnXDmnm5ldGAfabJZxhHgaMLtiB65WA+MknwwmbxTTO7JWGu0AGQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=arymSuFwklfPLOmYlNy8bZY5qdA7XbUIlSc8COvUre8=; b=kntRjpJOv/Te3dnQmT3vqTS+DdPVxEkjAgCnhrE7etdjcSZE/P0OVaIlNqJitN9TXzsumt1SRi/zF3uY2Unk99Uovgol1o4WiSskOeaj/aova8WcXd4xjeN0or3xJcdcvhLHqF7AZDfLQQSbHCTpmiKggIqL9rmSm1LvQTOONNy3GWlg9X2N14Yb2RQQa4/OttXTftA1Q1XezRNa9J1O7P0MY6Y3mO5LsYhgMHm+rbgjrhfBXHJwCiYu4UNojfsvIhnzmJCzDQJiO+T3lPQ/dNzVTF2EWtlLoVO8PLQtIZoslMGXPpQwKOhOrEWA0AA/NKHFlXq2ZIHFogJQ8DA16w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=agfOIlCjHnCmmHBumU2HTCwcfRjkr7v1w7FC5oDdMy0PkWdOV5OyjPbwq/HAkIRrPSUKeNFm4er+YbIdNBagLQ3LCGfLs41R78MP2SJYapR3iQdWtGYw9BxpKB3MzaYcn0mJ3E3lUv3bxvnXw2dU7R9wvUACPHVY7zuUG8o+0ZNwK7tuM9b4OBFVoPxESCXCN0NDqEXbmKb8TsA4hqwV8CZJ/Bcl3J9a4FMk6AOtqadech6HELTFZYsy+i7DY06hNSOjSDasrA5ym5KjV6gnuUZUlMmrKDFRX/uL9jJ8TvVIvtOlmhu8pM5VtjYdancH/5myoVxbcgLyxfxC28wkNQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dEQsY06Bg5KgcgA0V4aYi0PXK5EOoZWYHQoKydEsACgJ4WhzzI9pxGjOrO1D+2+Bo01/bo25p3WLJBraKq2HXs/vdoHvJ9vNENPl5p81kDUFqxyHvw7gygQg4k0IrAz0lP7mTAsH1WveHyL+Iubsv4hyQA1JSxtfAgyWTJFF8gJuwUcA1SHPUKrCylrJ+6Uyu9yNUwnnCTiBzx+uNX1+dBMStVDHAppsVJQF/6DKwYFUImSjsjBKqv7Q6YZV2HwtHkkQwxv7+PSAO75O5XJn2adnbLWQfWZ/aSnRfEeSzPlNImc3DSGsiVdjwDG4HTKndyX+r1/ikeX2oGiPpByo/w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 15 Jul 2022 07:18:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYktrASbKlS5xyGUK27wSgSLVuo616tdwAgALfc0CAAA5jAIAABItggAACa4CAAAWRQIAABX2AgAAC1iCAAALsgIABU/pA
- Thread-topic: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年7月14日 18:58
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: nd <nd@xxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Roger Pau
> Monné <roger.pau@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA
> status
>
> On 14.07.2022 12:49, Wei Chen wrote:
> >> From: Jan Beulich <jbeulich@xxxxxxxx>
> >> Sent: 2022年7月14日 18:37
> >> status
> >>>>
> >>>> Well, this makes the table complete, but it doesn't explain how you
> >> mean
> >>>> to fold the settings of the two command line options into one
> variable.
> >>>>
> >>>
> >>> No matter how many separate "numa=" parameters have been parsed from
> >>> Command line, the values of these original variables are determined
> >>> after parsing the command line. So the determined status can be mapped
> >>> to the new one variable from above table.
> >>
> >> Hmm, I was partly wrong - the initial values of both variables are
> >> indeed set from just the single "numa=" parsing. But later on they
> >> "evolve" independently, and multiple "numa=" on the command line
> >> can also have "interesting" effects. I'm afraid I still can't
> >
> > Can you provide some examples? This way I can better understand your
> > concerns.
>
> Take bad_srat(): you convert "acpi_numa = -1" to setting numa_no_acpi.
> Yet imo (matching the present model) numa_off shouldn't be affected.
> While your change is fine in practice for (current) x86, it is wrong
> in the abstract model (which is relevant when making things common).
>
Thanks, I understand your concerns now. In this case, I agree with your
suggestion in previous e-mail:
> int numa_disabled(void)
> {
> return numa_off || arch_numa_disabled();
> }
>
> with arch_numa_disabled() evaluating acpi_numa on x86.
I would update this patch like above sample in next version. And in
this way, I think We don't need the new enumerations and mapping table.
Cheers,
Wei Chen
> Jan
|
