[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Thu, 14 Jul 2022 09:55:11 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zhelHElerS/PLSCl+hS++8jQdHm5dviKAPMHRkrLOVA=; b=GIuQNzkbt9w2jH5SRL8qQdr5OcbIqbIiuih8PffehIys7eYGDZeHIbOXJv5tofvKDq/xFDjMkDCxABUn+lv3McYAcFLLWYKCdzhqduYlg6pXCNF0PbDwoZmwDk8REObJ4GBK7M73fPI0ANyrXxkrGB3UUOM35FfNC6IyIPGaQtvFlxgfdLgGWVawWGj2/CpSf473036Ck+YBjbNbcDwolQB5aiBnphYMYKQUpLUUT/Smh6mkXr+dXeUTpHWcjN2QFv8GUdwQ9D7ocl2FnVmQjXlhv4RdoZC/V8JgVzkGx6tG77Tcq9EZyLjxb1JSUupl5nDnrlRcU2SOcaFOnhPI2Q==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zhelHElerS/PLSCl+hS++8jQdHm5dviKAPMHRkrLOVA=; b=YKolNt4AkNRCLY7oEmzKBnPvKw3fkGat2EIyWrzhk/I7WHeEBP8nAZSh1fFk9j6LMUNfwu74QPNVVtXihGLH9GqV6q04stKbA59q0ec21/0kqsI5xHjLTvgieLziXqY1rfvSli5BY1RyRowaX+KO/oM9UjxLhOhQmVDN/fcbfLxQN9wk0C958qYQI3xyMX7fOrys7MVEifi4HyWZhkghejbE2l+vy3hMgIXnD2ZJbREHrWWqN1cyL4y3m9q5SERfDvOaLcMOIFLCTDnP4sEryU6VqvoqJF9HRzWnftr9blKTlRYZStXT2yqoBfeuxYrJntsB51uUNVVCBETKPeAA+g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Wr54NL1bo/QQrDKtS+0QZnGWTYb/4Oc96SqXJpXupY0uw2vZKlFlBwFTTULzKSc5Pas17k6/LrW+hFKKXB0lZuc5Q7Ls/SdQeQn073FmJP4qQ678fDcWF+cWz+yY7BjNb5CFi7KsoHZAQxOBp1UvxSvOOVMautY+2qASX7STk60btQOfgpayKvR4YH7Fa1QqumORTqIjm0vTZzY+gl0dE4sak67pn8TcBpAIZD6ih64BYECPGOopnx0md5UcWmXTLRlOif12+v4N+AUDkQBT81SlNYrje6jFuAujM5yD1pkAlr9OEewjJowi5Stfq+ePsPVKxv1nwOJxH/jvebYK1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EJWe6Xv0ZuRBE21P78pwHaP4pEq7EZYXB6lFUpFrztLSuBXlkWSr4xKLKQ6NXVCQXibsOKd19d4THyp6rjc65xpXXkjhKtI8Cphvv9GOYZHtZOt9i9RDzpiDUFPM27Uvg44LCxL6uBdBWtI+h4duaCXDU9Je7W1i1PL5B9/Qpwbp4Wgf3/adUw5Ao8a/EYtq44kaM0NZwefjzWIVh5jkotC4Qvfi86FPGVjhiHhkawiwawEV+RpClhXwwPuccaPwjLwGRaYmsgWuCo0imafr6wQuMTjtFwePAsADlMfDBPJww6kqZTlfB8vpgnCb41F7JIN9kao6Op7fEeyjkZF/BA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 14 Jul 2022 09:55:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYktrASbKlS5xyGUK27wSgSLVuo616tdwAgALfc0CAAA5jAIAABItg
- Thread-topic: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status
Hi Jan,
> -----Original Message-----
> >>
> >
> > Sorry for replying later, I paid sometime to check the code again,
> > and drew a table like below, I ignore two columns when numa_off=true
> > and acpi_numa=1/-1. Because when numa_off = true, ACPI srat table
> > will not be parsed:
>
> While I agree with this fact, the problem is that there are two
> independent command line options driving the then single variable.
> IOW numa_off and acpi_numa both turned on may still need a
> representation. In fact I'm not convinced we can eliminate the
> original variables. What we ought to be able to do is consolidate
> their values into the one single new variable you add, before
> ever evaluating anything. _Then_ I think I agree with the table.
>
> Jan
>
> > +-----------+---------+---------------+-----------+------------+--------
> --+
> > | original | col1 | col2 | col3 | col4 | col5
> |
> > +-----------+---------+---------------+-----------+------------+--------
> --+
> > |numa_off |true |false |false |false |false
> |
> > |acpi_numa |0 |0 |1 |-1 |x
> |
> > |numa_fake |x |x |x |x
> |fake_nodes|
> > |enum state |numa_off |numa_fw_nodata |numa_fw_ok |numa_fw_bad |numa_emu
> |
> > +-----------+---------+---------------+-----------+------------+--------
> --+
> >
How about update the table like this:
+------------+----------+----------------+----------------+------------+
| original | | | | |
+------------+----------+----------------+----------------+------------+
| numa_off | true | true | true | true |
| acpi_numa | 0 | 1 | -1 | x |
| numa_fake | x | x | x | fake_nodes |
| enum state | numa_off | numa_off | numa_off | numa_off |
+------------+----------+----------------+----------------+------------+
+------------+----------------+------------+-------------+------------+
| original | | | | |
+------------+----------------+------------+-------------+------------+
| numa_off | false | false | false | false |
| acpi_numa | 0 | 1 | -1 | x |
| numa_fake | x | x | x | fake_nodes |
| enum state | numa_fw_nodata | numa_fw_ok | numa_fw_bad | numa_emu |
+------------+----------------+------------+-------------+------------+
Cheers,
Wei Chen
> > Notes:
> > The following scenarios will make acpi_numa=0:
sanity check or hash computing in acpi_scan_nodes
> > is failed.
|
