[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build/xen: fix symbol generation with LLVM LD
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 6 May 2022 14:56:56 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ArrKCQKNcUdBZ27Feomc/vyeJEr4bMub3Aov7mlP2Y=; b=i9HrbU+0lmpY7ox5jTgYkVYlj/hHJZ61axuqCsKXhecc/EIryXb231eZafLxMa5lZfRRDXfzyC9McEWvaN/CiA5OwDkb0nIDjDowXTE4dX/7N2mY2abJOd+G5YmTXOawk1eQs72e8t4r7fGSh+MrRoPjhJavsfYzFaxp2DmK0xUnI4bHCwxEIukPNrgDWQaKD1zbxGsexc318NlfC0u958DJT9Z9BdKqADUOLekxbhd1PffCoBucqWu9fa4nqlM4HgcbhP/xH7NxdpW9izdtzP8Qc1JpIxrWKOMFA3bQJM5O8QzARw8k4GWIwSukdnT1BjDGDiNLQXLnMaIplt2WSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ka/qHkLopxGc6dxEzxiZVlJCO944mKaiM8Yhe3NDs1wcYroKPaC6Sg34uJ6y040fnVwbhO+Xh/McJPG3KGrMYPFUxivWISajr49UjrlmR9ADIPFrmRPxuf9fFjKOquhJsbEUEZ/wNuKUyeJSTuFhBwjIh0n0Est89X7UB8hpj0iIwBoCDb+km/ESDxCcjEt3ZV7o5Ju1NqwZpTzB/6OXyRBnTKo5e9tfq4T1FfkjyPP+GvvlN9D2rlrkUThJxIgJ+OQkKGe6mZCuwtR8C/L4PjsQ0QXkOo64TvCyt2TpCSzgBkaY+TST6GnYkD/CNsrrKs78i+DgY91PLorwFWAU3Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 06 May 2022 12:57:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.05.2022 16:21, Roger Pau Monne wrote:
> --- a/xen/include/xen/compiler.h
> +++ b/xen/include/xen/compiler.h
> @@ -125,10 +125,11 @@
> #define __must_be_array(a) \
> BUILD_BUG_ON_ZERO(__builtin_types_compatible_p(typeof(a), typeof(&a[0])))
>
> -#ifdef CONFIG_CC_HAS_VISIBILITY_ATTRIBUTE
> -/* Results in more efficient PIC code (no indirections through GOT or PLT).
> */
> -#pragma GCC visibility push(hidden)
> -#endif
> +/*
> + * Results in more efficient PIC code (no indirections through GOT or PLT)
> + * and is also required by some of the assembly constructs.
> + */
> +#pragma GCC visibility push(protected)
>
> /* Make the optimizer believe the variable can be manipulated arbitrarily. */
> #define OPTIMIZER_HIDE_VAR(var) __asm__ ( "" : "+g" (var) )
This has failed my pre-push build test, with massive amounts of errors
about asm() constraints in the alternative call infrastructure. This
was with gcc 11.3.0.
Jan
|
