[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build/xen: fix symbol generation with LLVM LD
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 6 May 2022 12:25:59 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K1/HN3TYj6xdaitfmXgNazLjDH8rKKK5HfSedp9HooM=; b=PJKEpw0Uer6/2eO6+L7I9BTZOLSR0iCtr3+enuqBsCGOpecugTkAHomt0C37mCg3Dh0aFN9hAvhfD7PRRL5txBNrgqwFGKXdem24XjNT8DKJdSYptdb1+ymjoMUCbyoRG7Ai334OwzAxp+vp6oKFRbVS5In8pF7OBc+NDd+1xkHEie4HOkUBKUrYCbPRWC2MF6yIccKSntybFyQGEUbfT43PLSaDCQNCHGwxWGv3ZdR/AH1swU7jOf8fyXf82RpMZ4vUgUUjz2Vw7SOHRe/aMvOykOYlGP/rV3BJPOAurGGh0uYS3NzlDjOWzb/BiMhUIFRaLP5Cw1zBOOU/fgRidA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K/BCjMHi4wzhCBqahURwlrO/8DC3bteRpDOekgrehIIxx2U7MF4mG+FfeZtTuy0eyEnMtwkwRFPcjmqOW0y7hoeSbCfhFzjt/hfKVgol0eqiMMjQ+3ETg8OTKFcqK9jTfa2JK23mBHxdrdJcBSYHv3RgGL6TKMyGkl7LnJmBZGxxDI0PRf8C/w480W2bPF0f2lbeeoJtB2DY04CFUnf8BU2aH/3FuL43D6UNehTasKEDEUZ7mgLSFph5uMRCGsk8sAcUEXGuvLsiy3oe+Yi7LQ4+On+J0aAdnJgFf6b8sVBoO4ydzmGmzB3WSiWeUgBLQic8yRlxqzNlHN/R8R8nKw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 06 May 2022 10:26:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.05.2022 16:21, Roger Pau Monne wrote:
> Current LLVM LD implementation will turn global hidden symbols in
> object files into local ones when generating the .symtab of the Xen
> binary image.
>
> This is different from GNU ld implementation, that will only do the
> conversion (or remove the symbols) when generation .dynsym but not
> .symtab. Such conversion breaks the processing of symbols done by
> tools/symbols.
>
> Use protected symbol visibility instead of hidden, as that preserves
> the symbol binding while not generating GOT or PLT indirections that
> are not compatible with some of the inline assembly constructs
> currently used.
>
> While there also make the visibility setting compiler support
> non-optional: compilers not supporting it won't be able to build Xen
> anyway, and will just throw a compiler error sooner rather than later
> during the build.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
