[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] xen/vpci: msix: move read/write call to MSI-X PBA entry to arch file
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Mon, 28 Feb 2022 12:23:54 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j6n9352ehEXwn+lvoYM1eerHSAe4r5q+VxS07xN90xU=; b=m9NYQFGwWYO6UnB9xchp1IEW6EzsbUmvdWXQdvBkrxRkzNCk/h5jqBMysy7EvfXRBlXcgIUakxiZHBIbxAuPdXSdIWmpmTHq1NXsuTBuRLKg5JJjtz2kPHpAzwFtMol9T0lopaJoUYvDXGevnhsmYXsoulcYzaFqbf56hejASiOlZDqXYBB8bZdc20LS/YAyB4ThmnNz5xbXDY2bpP8XbMdKqhu4juEc3yzIBnetgt2YgoEpzagryYz5/jHJI8OZTyyacgMt8WbsNthixREiPJ43J1EC7PmtPxKAzyeL9e6FCEK2XojQJWQ8JaIG+tqDcizNUwM2S6aX7e3LZCM22A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5EkRqJtHnTWF+Krep/Kea9/H5xJ57PgmstkE+NFj1jQVWSpgE37CdOjMgmFGJW5lwkd46hb1fE9zgIicyVdTf6zTCHf6MO3dWa2EZKv7f+YuphDMc6KoK7FhRVkF5UOwjIymt5ghmRnfrxUqReLbnQ4Ldh+d67T2+K7ktooAZVTPG49w99iQOdGf8eRUPds/eyWqqCTCv87bKnBqJYHdYr8p2D4WOg5lLWwrpTk6u14oCe6qlsPGWZzSFJQvZCSvG78OZGyjifc2zASTQB7vMWAvhCLq6uILf2sg3A+gRttGjo0iHk/8KMxXTmqCKW6u3mME7J4LfGqP+bNZjCqwQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 28 Feb 2022 12:24:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYIoCRIEW4rFyZskGyHhvFMB0R0ayj/BWAgAT7AwA=
- Thread-topic: [PATCH v2 3/3] xen/vpci: msix: move read/write call to MSI-X PBA entry to arch file
Hi Roger,
> On 25 Feb 2022, at 8:20 am, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:
>
> On Tue, Feb 15, 2022 at 03:25:18PM +0000, Rahul Singh wrote:
>> {read,write}{l,q} function argument is different for ARM and x86.
>> ARM {read,wrie}(l,q} function argument is pointer whereas X86
>> {read,wrie}(l,q} function argument is address itself.
>>
>> {read,write}{l,q} is only used in common file to access the MSI-X PBA
>> structure. To avoid impacting other x86 code and to make the code common
>> move the read/write call to MSI-X PBA to arch specific file.
>
> I think we agreed where going to unify {read,write}{l,q} so they could
> be used in arch-agnostic code?
We agreed to modify the vPCI MSIx code to use a pointer, but that not
helped me to make code arch-agnostic. I decided to move the PBA handling code
to an
arch-specific file to make the code usable.
Thanks for the series "vpci/msix: fix PBA acceses” series that will help to
use the
code for ARM arch also without any modification to {read,write}{l,q} .
Regards,
Rahul
>
> Thanks, Roger.
>
|
