[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
- Date: Mon, 28 Feb 2022 12:12:05 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BoN8B1+cDkPXX9B0BoNFj3nAifW7TvSeiefJpZxzqc8=; b=EjWnu2PT05DMYzDJp4x0o09cKzVFcEu7j03Q5aE23ykMoRHqQG20v8O+IOOL4X0AQtkn/Kel6LHlyAvvGmYA4BSK2lH3VgpnLIaUXrZ5igAMoGroT7rtVWG+qfoJbNtZ0nCZPl8rt0xVWHj8PlWnW7McMg/khV4SDFeoNaMxiWJ9xY8CAVvIwY8h/X0VL6xqCjD9d+vH2bAP1riKF+9pw0ZItAaf67mcaBR/qWfUcF+cWW8Es8sRFBznR7RyjrIpGtS00oQEn8FjeRScdQmgfyElagblugkyV1CpfjmL87yTWRUUTXdXfw7CBE1GMXgvovOUiqQxqDMgKvlzUGhl9Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RZy92LsyLFyneych8UrTzw6IdgEVsiu22FuoUM7BcL6afPdAPXU3tN5wru7DH1cNRM2Ao1d0k11pEBkQ4Kcu1lLtU5+dfxisH/LN3KMaPtDlsqs8tvoE3NN7HLVnIHreHSKYfUQqHjd0EIrpFZaFE8ObCavccAq3SW2g70mCFZVqPRtTzXIWZLiVwY7OS0h06O4TXXXLgA82XfjkBsA1cwQ7esbo9LgYg/CiDYGT7edxVf35+2H+oh3066rDOsItJNlFlR8RRjvrW6PdcOKT+7zMwAlD19UXcXCRt6//2HbAkpuEo0HDmHzqQjhXiwTQF//dptklWEU7P5NuUNQayw==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "Juergen Gross" <jgross@xxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "George Dunlap" <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 28 Feb 2022 12:12:23 +0000
- Ironport-data: A9a23:UneF6Kn9EdmDPfQlRy0OVc/o5gwwJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJKW2GEPf6NZjShfNp3ao3lpx4EupSDnIQ2GQE4pSk8QiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EoLd9IR2NYy24DjWVzV4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYbxcbH7CWpr0hUjZzHyRXZ6haxOHDGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3mHhmwHf8BPIvRZnFTo3B5MNC3Sd2jcdLdRrbT 5RFNGcwMU2cC/FJEmgzK7R5scCPv3W8aCxGgUinu/Rr7meGmWSd15CyaYGIK7RmX/59lEuCu njP+Wi/BxgALcGe0hKM6HfqjejK9QvFX4YVGKy95+RdqlSZzWwOCzUbTVK+5/K+jyaWWc9Zb Uod+SMsrK073E2tUtT5GRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQp2 0GImZX1BDVpmLyTVX+ZsLyTqFuaJiw9PWIEIygeQmMt4dPuvYUyhRLnVct4Hei+ididMTP/2 TeRtwAlmq4ey8UM0s2T5kvbijihopzISA8d5QjNWG+hqARja+aNZZGs6FXdxeZNKsCeVFbpg ZQfs5HAtqZUV8jLzXHTBrVWdF202xqbGBvMs39yRad4yzWC0HKmVNpV/A0gIH48Z67oZgTVS EPUvApQ4rpaM32rcbJ7buqNNig68UTzPY+7D66JN7KidrA0LVbap382OSZ8ykiwyBBErE0pB XuMnS9A514+AL8v8je5Tvx1PVQDlnFnnjO7qXwWIn2aPVuiiJy9FO1t3LimNLlRAEa4TOP9q Ys32yyikUg3bQEGSnOLmbP/1HhTRZTBObj4qtZMasmIKRd8FWcqBpf5mO19Jt01wP0MyrmQr hlRv3O0LnKl2BUrzi3QNxhehE7HB84j/RrXwwR2VbpX55TTSdn2t/pOH3fGVbIm6PZi3ZZJo wotIK297gB0Ym2foVw1NMClxKQ7LUjDrV/ebkKNPWlkF7Y9FlOhxzMRVla2nMX4JnHs7pVWT nzJ/l6zfKfvsCw5VJeGMK/0lgjp1ZXf8corN3b1zhBoUByE2KBhKjDrj+9xJMcJKB7ZwSCd2 RrQChAdzdQhaadlmDUVrchod7uULtY=
- Ironport-hdrordr: A9a23:SU8YuakqeJutfaBqSa6TWWbM9qTpDfOBimdD5ihNYBxZY6Wkfp +V88jzhCWZtN9OYhwdcIi7SdS9qXO1z+8R3WGIVY3SEzUOy1HYUL2KirGSjQEIeheOutK1sJ 0PT0EQMqyIMbEXt7eY3OD8Kadb/DDlytHouQ699QYUcegCUcgJhG0ZajpzUHcGPzWubaBJT6 Z0jfA3wwZIDE5nCPhTcUN1ONQryee79q7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X XFuxaR3NTij9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDt1L9qqq iPn/4TBbU215rjRBDznfIr4Xin7N8a0Q6m9bZfuwq7nSW2fkNjNyMLv/MnTvKQ0TtfgDg76t MQ44vRjesnMTrQ2Cv6/NTGTBdsiw69pmcji/caizhFXZIZc6I5l/1VwKr7KuZ0IMvW0vFvLA BVNrCV2B+WSyLvU1nJ+m10hNC8VHU6GRmLBkAEp8yOyjBT2HR01VERysATlmoJsMtVcegI28 3UdqBz0L1eRM4faqxwQO8HXMusE2TIBRbBKnibL1jrHLwOf3jNt5n06rMo4/zCQu1D8LIi3J DaFF9Iv287fEzjTcWIwZ1Q6xjIBH6wWDz8o/sukaSReoeMM4YDHRfzO2zGyfHQ08n3KverKc qOBA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYJO06JWynylsFtkyl8WR8WaDosKyixjKAgAGyPACABChhAIAATiCA
- Thread-topic: [PATCH v3 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86
On 28/02/2022 07:32, Jan Beulich wrote:
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
> unless you have verified the sender and know the content is safe.
>
> On 25.02.2022 17:02, Jane Malalane wrote:
>> On 24/02/2022 14:08, Jan Beulich wrote:
>>> On 18.02.2022 18:29, Jane Malalane wrote:
>>>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
>>>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
>>>> and x2apic, on x86 hardware.
>>>> No such features are currently implemented on AMD hardware.
>>>>
>>>> For that purpose, also add an arch-specific "capabilities" parameter
>>>> to struct xen_sysctl_physinfo.
>>>>
>>>> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>>> Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>
>>>> ---
>>>> v3:
>>>> * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually
>>>> set arch_capbilities, via a call to c_bitmap_to_ocaml_list()
>>>> * Have assisted_x2apic_available only depend on
>>>> cpu_has_vmx_virtualize_x2apic_mode
>>>
>>> I understand this was the result from previous discussion, but this
>>> needs justifying in the description. Not the least because it differs
>>> from when XEN_HVM_CPUID_X2APIC_VIRT would be set as well as from what
>>> vmx_vlapic_msr_changed() does. The difference between those two is
>>> probably intended (judging from a comment there), but the further
>>> difference to what you add isn't obvious.
>>
>> Okay, I will make that explicit.
>>
>>> Which raises another thought: If that hypervisor leaf was part of the
>>> HVM feature set, the tool stack could be able to obtain the wanted
>>> information without altering sysctl (assuming the conditions to set
>>> the respective bits were the same). And I would view it as generally
>>> reasonable for there to be a way for tool stacks to know what
>>> hypervisor leaves guests are going to get to see (at the maximum and
>>> by default).
>>
>> Like the "cpuid" xtf test allows us to?
>
> I don't think I understand the question. That xtf test is concerned
> about checking the CPUID output it gets to see itself. It doesn't care
> about what other guests might get to see, nor the maximum and default.
>
>> Makes sense to me. I'm happy to take that up after.
>
> "After" what?
So I meant to say that I could add the Xen CPUID leaves (40000x...) to
the policy so that toolstacks could know what hypervisor leaves guests
are going to see - in a future patch, as this wouldn't just expose
XEN_HVM_CPUID_APIC_ACCESS_VIRT and XEN_HVM_CPUID_X2APIC_VIRT
(0x40000x04) but other features too.
But, at the same time, w.r.t. this patch in particular, using
XEN_HVM_CPUID_APIC_ACCESS_VIRT and XEN_HVM_CPUID_X2APIC_VIRT to detect
assisted APIC gives us less flexibility to add more fine grained
controls in the future.
Thanks,
Jane.
|