[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v9 04/30] build: set ALL_OBJS in main Makefile; move prelink.o to main Makefile
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 28 Jan 2022 12:41:38 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ng4cWlIouCpGvfbfFpdMWlqZ7oGFx6uPQrKT4270Aco=; b=RAU674MzRR3KHcfk03iM9LKvlMzrOCkqHF4n9gukKY2W0ml1uCEaL3tc4K07pjhMt3bCIao5HES1W9iWAb0M+tsBB2pUf9U/tR1Pwffn10VG9vMCNU0KRS+sJifedM6T7dO/SsUqYR1sc6WWziJpzu2jWs15EtJWpzulNXK8k17V+x2cc5R5tJHostgchRfS6B/QGkoWn/zWzbT4UTfcRqBwh7NTV3Mur+oN84mZKVE2rvGkj5xHRI+dTQVIHd1H3kWIQeL36WKw1yvOhyIP7fmCUo6oLf7AthUyJBRnMsTM1kfyrsm/QooLDHxrs7f+anpoQtUA3DnVAn1hnY6CjA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UJVUsxHLk3X64jNJre5xPQHvrPtwl4By+OTjI+IO9zYL9g02Kz4vsq7F/1qZawnOZsoZ64BWXa9vBA1agv5AJmCtjYKJtYy/kGmtgo6RBkeHDjiEV+hoaAfL1rkZnQJABo2/rDuhTJW/zZUNBqGiYEviBBcm1UAvKuS+NMUVfi/GbFHOwjpUVx1VNjOxPLJ80xw3mAi1sCSlUS/xPkJwzxFdJvU4SEwflyn+ddKdxCrDWy3X5/I9UgwsryTveA3FT6+y4gBnRqJs9oE7nY9vEGVRNWJ3KME+0rLJkr+FM9sapFEbFF+KsXSqHnFuHkKnZgtf617sNRyfatm+0Jp8qg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 28 Jan 2022 11:41:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.01.2022 12:32, Anthony PERARD wrote:
> On Thu, Jan 27, 2022 at 04:50:32PM +0100, Jan Beulich wrote:
>> On 25.01.2022 12:00, Anthony PERARD wrote:
>>> --- a/xen/Makefile
>>> +++ b/xen/Makefile
>>> @@ -285,6 +285,16 @@ CFLAGS += -flto
>>> LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so
>>> endif
>>>
>>> +# Note that link order matters!
>>
>> Merely as a remark: I wonder how applicable that comment is anymore.
>> If anything I'd expect it to be relevant to $(TARGET_SUBARCH)/head.o
>> (Arm) and boot/built_in.o (x86), neither of which get named here.
>
> Indeed, the order here probably doesn't matter. I tried to build on x86
> with the list reversed (so still leaving boot/ first) and the build
> works. I didn't try to boot it.
It's quite unlikely for the order to matter at build time. Being able
to boot the result is the minimum. Even then you can't be sure you
merely avoided the problematic piece of code on the particular
hardware you did the test on. Perhaps the most fragile parts are
sections holding pointers which get processed in the order the linker
put them. E.g. unexpected interdependencies between initcalls.
> Maybe it's time to retire the comment?
Probably, but Arm folks would want to confirm that's fine on their side
as well.
Jan
|
