[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v9 04/30] build: set ALL_OBJS in main Makefile; move prelink.o to main Makefile
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 28 Jan 2022 11:32:15 +0000
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 28 Jan 2022 11:32:29 +0000
- Ironport-data: A9a23:V+nho6rsg4A133KS00Qf+7YKUoteBmKyYhIvgKrLsJaIsI4StFCzt garIBnTOvneN2ahLopzaoixo0xT6JCGzd42S1A6rS0yHyIW85uZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlZT4vE2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw2ILpW1jlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnbKUEUBwMbXXobs2VgdUHg10MrMbv6CSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O ZdANGE2PUmojxtnJ3Y+L6pnvOCRgHjScXpFjHOupLANyj2GpOB2+Oe0a4eEEjCQfu1rmUKfq nPD7n7OKBgQP9yCyhKI6nupwOTImEvTUo8ICKex8PIshVSJ33ESEzUfT179qv684mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O/I+wBGAzOzT+QnxLmoOQyNFadcmnNQrXjFs3 ViM9/vrGDhuvbu9WX+bsLCOoluaIjMJJGUPYSsFSwot4NT5pow3yBXVQb5e/LWd14OvX2uqm nbT8XZ41+57YdM3O7uT03SfxGujvoPwESUw+Anacmiq8F4+e9vwD2C30mTz4fFFJYefa1COu nkYhsSThNwz4YGxeD+lG7tUQuzwjxqRGHiF2AM0QcF9n9i40yP7JehtDCdCyFCF2yruURvge wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtNiJNrKigbArLWdrGR2Cg2bKgggBd2B3yckC1 W+zK5rEMJrjIf0PIMCKb+kcy6Q34Ss12HneQ5v2pzz+j+bFPiXNEulYaAbfBgzc0E9iiF+Lm zq4H5DSoyizrcWkOnWHmWLtBQ5iwYcH6WDe9JUMK7/rzvtOE2A9Ef7BqY7NiKQ+95m5Ytzgp ynnMmcBkQKXrSSedW2iNy4/AJuyA8cXhS9rbEQEYAfzs1B+MNnH0UvqX8ZtFVXR3LY9nacco jhsU5joP8mjvRyeq21CNsGs9dI7HPlp7CrXVxeYjPEEV8YIb2T0FhXMJWMDLQECUXi6s9UQu bql2l+JSJYPXV06Xs3XdOiu3xW6un1EwLB+WE7BI99yfkTw8dc1d3yt36Fve8xcew/ewja61 hqNBUtKr+f6vIJoosLCgrqJrtn1HrImTFZaBWTS8Z2/KTLeoji42YZFXevRJWLdWWr49b+Mf +JQy/2gYvQLkEwT69h3EqpxzLJ47Nzq/ucIwgNhFXTNTlKqFrI/fSXWgZgR7vVAn+YLtxG3V 0SD/shhFY+IYM61QkQMIAcFb/iY0a1GkDfl8vlocl7x4zV6/eTbXBwKbQWMkiFUMJB8LJghn bU6oMcT5gGy1kgqP9KBgnwG/miANCVdAaAut5VcC473kAs7jFpFZMWEWCPx5ZiObfRKM1Urf WDI1PaT2ewEyxqQaWc3GFjMwfFZ1MYHtx19xVMfI0iEx4jejfgt0RwNqTk6Q2y5FPmcPz6f7 oSzC3BIGA==
- Ironport-hdrordr: A9a23:dMSS56BcTpKH6cTlHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/ xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U 4KSclD4bPLYmRHsQ==
- Ironport-sdr: uJT9nUtCfec8y9bMNecZjcfkqlY6PtU3UBiAAvtOU+YTcFwJP0lHQwW//7vPAGmYiSsAbS6PmV fPG+PLRIVOfL2cCcxarx/MoHsb639EmL2LbTuGVf86iuhuvf8sls5iIF58yk7I1Vh0PFntxxNr nN8JIVK+IGa0C6XBUxkuPeDBwRb/JL7d56NqyN9M7SmX35fb+3q3ViIFwx98IS8Fbdmu9GUz4S IrUh+DiNdHPE5ozUgZT8UxcWFzzD3PQRdCRPDY3zc1i4+WI1mQRPCmBY0ujvTZg8za5+Ga6nWK Hqyie2U1v1+wAwNSKLlDQNvj
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jan 27, 2022 at 04:50:32PM +0100, Jan Beulich wrote:
> On 25.01.2022 12:00, Anthony PERARD wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -285,6 +285,16 @@ CFLAGS += -flto
> > LDFLAGS-$(CONFIG_CC_IS_CLANG) += -plugin LLVMgold.so
> > endif
> >
> > +# Note that link order matters!
>
> Merely as a remark: I wonder how applicable that comment is anymore.
> If anything I'd expect it to be relevant to $(TARGET_SUBARCH)/head.o
> (Arm) and boot/built_in.o (x86), neither of which get named here.
Indeed, the order here probably doesn't matter. I tried to build on x86
with the list reversed (so still leaving boot/ first) and the build
works. I didn't try to boot it.
Maybe it's time to retire the comment?
> > @@ -407,7 +417,7 @@ $(TARGET): FORCE
> > $(MAKE) -f $(BASEDIR)/Rules.mk -C include
> > $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include
> > $(MAKE) -f $(BASEDIR)/Rules.mk
> > arch/$(TARGET_ARCH)/include/asm/asm-offsets.h
> > - $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH)
> > MKRELOC=$(MKRELOC) $@
> > + $(MAKE) -f $(BASEDIR)/Rules.mk MKRELOC=$(MKRELOC)
> > "ALL_OBJS=$(ALL_OBJS-y)" "ALL_LIBS=$(ALL_LIBS-y)" $@
>
> I'm always a little wary of using double quotes when it's not clear
> what exactly a macro may expand to. Single quotes at least have less
> restrictions ...
Using single quotes sounds good.
Thanks,
--
Anthony PERARD
|
