[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 10/37] xen/x86: use helpers to access/update mem_hotplug
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Wed, 26 Jan 2022 07:58:03 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UIdEhz/BIFjdqJHRVY2Uz1FboT+J093GoPvwKt6omwA=; b=en3TEFFhW1oGzWIJIyo80l9NvxkKdHVrRymQi3Msjx6+XeoIHcGA6sgdieETts0nrIn4WRlJANkVPjppTLNPZwsoZ9ZZ/OcnWNnA87a25aJuPWe9O11M+z1I9TnmpzLVjEBy/lveH6ekzBZ/CAoA1gcptTV+UVuVz1yira/Piot2B5bUMqUc5W59SUbvVxeNx4wGspNVR/0dSC1bQFDumqMDwFv6+m3619g2h4JzbJtSyOijvhFb3ewSDJpZSZW9b1kSSzWWYcbCIOP/BnYND+HD4WWngdrnFqlBb8DMiuFM7OoHEfGmG9uogwDtCJntooTEIglScWqBmShmsy5T4A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l495A3F5/4iZMIvRaO8n/eezVlh7w8FQVrxIl2ges+UbgFkOJ3HYYDQ2BQrvpr68wgp3sJhBMt+DYzsL+uiitMhSjkvQAUTfFNavFxnKwQNoxUaLLLfjktArc1QcujJGLLgA1zwgxh3vmExAHoEpfQi5cyod5KDM3dX1Xm+eMIIf+ZT1WmFlugVsiHY63it+fX3qHHVp9WOLT9H+iMX6qD/UNfXHH6jGRvZnzQCJ4mzUXASYipldGijTisCf0E1GeVEcGtrVCV/DP84JpNbguF1sTkxCcPPHmYOVjrWkutmkcaZvVmJi2LJlLw5RsngvzAN4z8tGJUZL3Xw4eNeEXw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- Delivery-date: Wed, 26 Jan 2022 07:58:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXsHMVa+NLaHkUKUKV++B1/dWC4qxzHlUAgAKVd/A=
- Thread-topic: [PATCH 10/37] xen/x86: use helpers to access/update mem_hotplug
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年1月25日 0:30
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 10/37] xen/x86: use helpers to access/update
> mem_hotplug
>
> On 23.09.2021 14:02, Wei Chen wrote:
> > --- a/xen/arch/x86/srat.c
> > +++ b/xen/arch/x86/srat.c
> > @@ -391,8 +391,8 @@ acpi_numa_memory_affinity_init(const struct
> acpi_srat_mem_affinity *ma)
> > memblk_nodeid[num_node_memblks] = node;
> > if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
> > __set_bit(num_node_memblks, memblk_hotplug);
> > - if (end > mem_hotplug)
> > - mem_hotplug = end;
> > + if (end > mem_hotplug_boundary())
> > + mem_hotplug_update_boundary(end);
>
> Can the if() please be folded into mem_hotplug_update_boundary(),
> eliminating (at least for the purpose here) the need for the
> separate mem_hotplug_boundary()? As said on the previous patch,
> I think the two want folding.
>
Yes, these changes would be more make sense. I will do it in next
version.
> Jan
|
