[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 09/37] xen/x86: introduce two helpers to access memory hotplug end


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Wei Chen <Wei.Chen@xxxxxxx>
  • Date: Wed, 26 Jan 2022 07:53:46 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FpWhxK+4sylmCM2zs4mWtv7k94dMFNXnXzWCQjTuVSw=; b=eT7QWeQ5CeuRItUdC8OSynP+bmSEr9boL0RHYwVMh23uGHMqDMJxxdpAQuHZYZjxJdFi2MvSo6s59L1RTR6j3fE9SQf8oR0kfLzfs9RfhhgT1SduaoNETRWlYj0nm/3jwIzX3IjGimL8XNWIKuZHvRb9nbos0hR5NyUkkn6sP3iPdo1k/qgP9WLc/xVFC0x5kF03s9lQnSfMf9zS2STzs420fBF7ynrlcP3V0+ug4vjBmatZFZ0kTL5MflEcU5MwyDUrRbRLkSpKjsqmX6Da0aA1M0w/0MVqCtoYWJJlof7WE/ysTlMlqVnuEzGA6hVdufWhJ8VyxfZFVC5nvsMnlg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h9USPKFQDbB2xGrfczm86nRMxyrIf8t2ABksj/IG4Jy2qhM5yi8k66DPbCU7kDGXHzUwJNrkEzUYoX6C0UtTlDmKX13a4bEe8H5W1iVgkVkVXgC6ZQSQY1R2qcuw9hkZZ8B4yq2hE4T86PTNTmyrvyTqVzvJ0B6Ys+C62jRvvJle6HY4Jbz6X4GP/y83zCxolpypXxzFJqnaQVMa86scHn+2jYxGv3ocKC/V5aTa5d1ImnTNwMIlUUwuHXgE5jN9nbHrL6L7zQ8YMsDc/YXlDQTVOUUdku88Gg8FpK84roAjvjIVuxpGLiP3inv3t42d99L+gU+pos/vbKoVRi30Nw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
  • Delivery-date: Wed, 26 Jan 2022 07:54:09 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXsHMSm4kTUY1aDkqu1iaKpcFN+KxzHOkAgAKVffA=
  • Thread-topic: [PATCH 09/37] xen/x86: introduce two helpers to access memory hotplug end

Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年1月25日 0:25
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 09/37] xen/x86: introduce two helpers to access memory
> hotplug end
> 
> On 23.09.2021 14:02, Wei Chen wrote:
> > x86 provides a mem_hotplug to maintain the end of memory hotplug
> > end address. This variable can be accessed out of mm.c. We want
> > some code out of mm.c can be reused by other architectures without
> > memory hotplug ability. So in this patch, we introduce these two
> > helpers to replace mem_hotplug direct access. This will give the
> > ability to stub these two API.
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > ---
> >  xen/include/asm-x86/mm.h | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/xen/include/asm-x86/mm.h b/xen/include/asm-x86/mm.h
> > index cb90527499..af2fc4b0cd 100644
> > --- a/xen/include/asm-x86/mm.h
> > +++ b/xen/include/asm-x86/mm.h
> > @@ -475,6 +475,16 @@ static inline int get_page_and_type(struct
> page_info *page,
> >
> >  extern paddr_t mem_hotplug;
> >
> > +static inline void mem_hotplug_update_boundary(paddr_t end)
> > +{
> > +    mem_hotplug = end;
> > +}
> > +
> > +static inline paddr_t mem_hotplug_boundary(void)
> > +{
> > +    return mem_hotplug;
> > +}
> > +
> >
> /*************************************************************************
> *****
> >   * With shadow pagetables, the different kinds of address start
> >   * to get get confusing.
> 
> Imo for this to make sense you want to also use the new functions
> right away in the place(s) where the direct access(es) get(s) in
> your way.
> 

OK, I will merge this patch with the patch that will use these
functions firstly. 

> Jan


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.