[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RFC v2 5/5] x86/mwait-idle: squash stats update when not actually entering C-state


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 20 Jan 2022 17:21:31 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QrCBTeVRwjhh07tLu/3BOEPrlF7xXrcDvKfEZW8TW34=; b=KHCwOKqUlsunk9uPo2GoXjNR7fK+IkmehMGqxAxoHBRNgMKIj/j2/qafdwVoi5rx4oJCgbf07JndMJ41bCOcq1luf4+EwRYH3EVvJ0sGerOhDmvqiKm66FoSJhZcOdl0ZKIyaZrgWLElsVeKGTtqKioIKTVcR9MQBItJTG03AzuL9OCd2aBRp1wXHQ0UzkbJFiGzScejDG/eGNB2vczr1ueNr5iac2hoNa44n+zlZ5bEVKAdIoSe9+8n1gM/6nWQavTLYdlKHuL+BAgqV99WR4KQYlis+s6hxHq33hGNC/RMdOIeA+/pUgAZ3pc7ml+JAuXagvkJFanO5HWvWRX+qQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FQBe7/EWCKtgBxpku9VNiHjmuy6VCGfZxxx+3nKS6PVwRegS5T9gk4eYyFW0OzdBfuHd4CwnZVMtXA5jJARmvIYuVZLsy6w3EX3cp0XlApIQhHiNj1HHoc8aMlcixOb1HzzIhFHyx2FVn7VIZ1RLzx/YqFyJkIsW8wqcyxuTHmhVhVl7AQDaiH02DU7zIpSIUVToWQzsATzAGhEp9Vq8RsovCONTtiWPQpLVAgAguYzEmkXc1OgPQIAJwfdF634o7xRKhNB03ixNjRxfhAJ3ESyITyZSa7UmlBrjDtDDnabOSA8uy4lxfWftnwDSV1sQ7v4IeLAj1fIF7p2iUGNLjw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 20 Jan 2022 16:21:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.01.2022 17:00, Roger Pau Monné wrote:
> On Thu, Jan 20, 2022 at 03:05:12PM +0100, Jan Beulich wrote:
>> While we don't want to skip calling update_idle_stats(), arrange for it
>> to not increment the overall time spent in the state we didn't really
>> enter.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> RFC: Arguably more of what follows could be moved into the if() -
>>      thoughts?
> 
> I would move at least the restoring of the TSC, but I would be fine
> with moving everything up to local_irq_enable unless I'm missing
> something.

Yes, that's what I was considering.

> I think you could likely also avoid the call to update_idle_stats so
> there's no need to fetch the new tick count.

No, this call cannot be bypassed. At least not without further
rearrangements elsewhere.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.