[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v8 27/47] build: grab common EFI source files in arch specific dir
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 18 Jan 2022 14:49:37 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OiSrMyvy11sETXxtcHBLqKvAV6wHG1/jA9t2YzsOriY=; b=K7d88YkaLx53DWw82G+f/qcFYCVmktDtYLbFFgPCy2+/bxDu3ZGwrgXGXcviMa/kOJSbZfjcAo6KN3axlcRHZMx+SiltTIGOAKZPGk0SI0VuTwfI0XLAG18wv1BkDXom29IdIPTLXIuDeAmK+k+Tt3Wp6F5QZfJGYiTpX72306IRKaxnha2PI7LqIJ3ROYGMd97ZFBn4HeXlhUpHXzfuhPTJyJlER9T6laNHXNw1R26CcjHXngCbc9kYZ5Ds9ZxEcGWFasHroF7e4GrXvZSxqISkN4vY8VFSqwSUPW4Tk+PwP/GXBUGxEwvPWv2fE6w/x4zgB0ElrUo8MVl5zQOteA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ec3l84c5El+qpJBOfWF6zHvSki3+tlJhaE2YiOzjcf4MyjNsSqWwLoHB0amEWC7uHJs+z+IH5sUQUnxjtLQpi/b9FjPGkJZ5f9UyuSqkNEj4RRrWPFk8G8SdqnhCdxQ93a38t8AnDMy5iWFwQhw+TKjJyPZjB6lYPhk9mCb4REew/SVXWkkNnQBrsYfjEpACqXgMLwTSxnR9Law9a2AMDHKrqeS6X0flogfK7TCkmFplXOPTDk6uGwlIZNcv2SDzyWa/LH97FKw5GgT07CAuB4SFPm08vsFyDEDaZ+v5l9Ezkdrc+BwgN80GIqK5YR5hHDuzcwvobaXIMhb/I3m64g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 18 Jan 2022 13:49:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.01.2022 12:06, Anthony PERARD wrote:
> On Tue, Dec 21, 2021 at 02:53:49PM +0100, Jan Beulich wrote:
>> On 25.11.2021 14:39, Anthony PERARD wrote:
>>> Rather than preparing the efi source file, we will make the symbolic
>>> link as needed from the build location.
>>>
>>> The `ln` command is run every time to allow to update the link in case
>>> the source tree change location.
>>
>> Btw, since symlinks aren't being liked, would there be a way to make
>> things work using vpath?
>
> No, that's not possible. With "vpath = /build/xen/common/efi", make
> would look at path "/build/xen/common/efi/arch/x86/efi/runtime.c" to
> build "arch/x86/efi/runtime.o".
But /build/xen/common/efi/arch/x86/efi/runtime.c doesn't exist (and
never will afaict), so wouldn't make go on finding the file elsewhere?
>>> +clean-files += $(patsubst %.o,%.c, $(EFIOBJ-y:.init.o=.o) $(EFIOBJ-))
>>
>> Nit: Please be consistent (at least within a single line) about blanks
>> following commas.
>
> You mean to never put spaces after a comma because they are sometime
> significant? That's the only way I know how to be consistent.
When spaces are significant, they of course cannot be stripped. But here
they aren't (afaict), and hence
clean-files += $(patsubst %.o,%.c,$(EFIOBJ-y:.init.o=.o) $(EFIOBJ-))
or
clean-files += $(patsubst %.o, %.c, $(EFIOBJ-y:.init.o=.o) $(EFIOBJ-))
are the two consistent (in my eyes) forms.
Jan
|
