[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v8 26/47] build,x86: remove the need for build32.mk
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 18 Jan 2022 14:44:37 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YowkjhqgZsRcfRARselDYsf8HqzUDToEU+CM+fbKVsM=; b=CcSohgQVWdM6qFDDqd+IxxVLaE59OemfyWOFEQRWK1HGlwTPkWAUcMna+4iBqydbYaMY1hEvLI9efbUQpQjfjCOtSHBQ1AKOrpquZ19brQa/ERK3o546TC4nKnI83glCp1ka57yCc6TPbqgAPrBlscYJ99QmFfNUv8H82r6QEp/agrBSbbFfoXFV1XJgTHQeXP81nJaCRM0j9KrKjK1XdYCp4Z7PCpYLNJQmd9ET6C+KoZDfLXt2/tioR6fOAlljkGV8V0lLY9kFo0gKPw3pVOPta5yp4c+kvvTWsLBY1k6TD7du293b2E0WYVuiqQFAn9YngMMqFCcby1LXZi82xg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlejXKPnfBCCkcSNcZlLcYwQ++ejsgq8Trrj2ZW/kVfQCvK97NkKbxj6KmTf7VW+C1Ia7C8ntnRm3X7c/EdOi1WCU93cICZSspTpQy6Qd8e0ZnWdLWF4jyrHWWuyi9Mq4xh5lJ8VCbnyMiHQy4e6Q1bMgS+2lmVoWEWQ+F2qfmIkpVEPKAuWzsy5dOLbvw1guHpYuke01EXIwcVMhk4ghjtaJi/e82mH8b7Mz1p4WcPiPGhQf5HC/A5FXnWsMNFtcaPLmzo0x2DRwauz3qLRCZv8xgyykqU545cjnVAPFeKIusPFuAxNtYAkowMKQPwHogmv7ZoS9ld0K/gh3GVnQg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 18 Jan 2022 13:44:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.01.2022 11:50, Anthony PERARD wrote:
> On Tue, Dec 21, 2021 at 02:33:18PM +0100, Jan Beulich wrote:
>> On 25.11.2021 14:39, Anthony PERARD wrote:
>>> --- a/xen/Makefile
>>> +++ b/xen/Makefile
>>> @@ -171,6 +171,10 @@ export LEX = $(if $(FLEX),$(FLEX),flex)
>>> # Default file for 'make defconfig'.
>>> export KBUILD_DEFCONFIG := $(ARCH)_defconfig
>>>
>>> +# Copy CFLAGS generated by "Config.mk" so they can be reused later without
>>> +# reparsing Config.mk by e.g. arch/x86/boot/.
>>> +export XEN_COMMON_CFLAGS := $(CFLAGS)
>>
>> For my own understanding (it's hard to check being half way through the
>> series): At this point there are no further adjustments expected to
>> CFLAGS?
>
> I'm not sure what you mean. The comment should be explicit.
>
> CFLAGS is going to be adjusted after the copy, for the benefit of all
> the 64bit code (when building x86_64). The "renamed" to XEN_CFLAGS to be
> useable by the rest of the tree.
I guess I misread the comment, sorry.
> The name "XEN_COMMON_CFLAGS" might not be the right one, it is only
> common to everything in xen.git, so same flags that the toolstack would
> work with.
XEN_GLOBAL_CFLAGS would come to mind, but is unlikely to be viewed
as significantly better. Maybe XEN_TREEWIDE_CFLAGS?
Jan
|
