[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v8 12/47] build: build everything from the root dir, use obj=$subdir
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 21 Dec 2021 08:55:26 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IsxppLuFbpcMhrCnFc1ICeRDJ58oDWZqxda8HtzEPuQ=; b=e572zwejZk7hg0pRysSKz9F+LEPuBnP5I7dO1V4mzjnx2DxaS9u6gEDQ+tdtuR9bu+JHYkeN0bQfg/eaY06Oe34w97cHP1beAeAguxAKKvKKQ9YQkNFr5hRMT8iIc42vnG/gkQxE4z8Ec2A+jn/APRDwo/VxpTi6NNkDGxV0PHrrVDRTkOVWY/ppepgj/iYoQmrRCKueBpU9Ynpq40xdN8ClalzsSAGbX2aMucWP3iedUMtpVVh7jpt9Lh2m1BEvm7byAjpKYy0i9W2wU5hOulsPlUdJN+e0UC/wq5E1Fgj9Lw5nvwG8h9P4enJXPx+EuN/SS+JknEd2tHEtxn1z8Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l0xcjxlM4moCP90RWRhsM5KjABJoRm5bHfoLU904WI6Lf63/YGb36csnh6FiZdWdhsfiKBCUle+tPqZ/Bqssgpnlghlz1qNvKif5jIY+k8phfIBvgGlqEmGQ0xcZMvt2zxMm3Yd1m3Qh3d3CNW7JtzkYgjHpOZ9b1TxsGN2HgATevnvkHd3rhmDysAF95LjzZ0HzyauQcniZPnulMzZPJG7e2e4FVXxU8d3054c4YDEzKEGkskWQyLR/zgt2cVrFc0hsBDLSJB/HtlMVHy6XYT07cTJBfjn4ieHt1tueL8bwru7BG4c+67k8IBYdhQLDMdDSPFtsKlrlihP1ymd+wA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 21 Dec 2021 07:55:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.12.2021 12:29, Anthony PERARD wrote:
> On Thu, Dec 16, 2021 at 11:08:47AM +0000, Anthony PERARD wrote:
>> On Tue, Dec 07, 2021 at 12:10:34PM +0100, Jan Beulich wrote:
>>> On 25.11.2021 14:39, Anthony PERARD wrote:
>>>> --- a/xen/Makefile
>>>> +++ b/xen/Makefile
>>>> @@ -22,6 +22,15 @@ export CHECKPOLICY ?= checkpolicy
>>>> export BASEDIR := $(CURDIR)
>>>> export XEN_ROOT := $(BASEDIR)/..
>>>>
>>>> +abs_objtree := $(CURDIR)
>>>> +abs_srctree := $(CURDIR)
>>>
>>> Nit: In line with e.g. obj-y I think these would better be abs-srctree and
>>> abs-objtree.
>>
>> I guess that would be fine, we don't need to keep the same spelling that
>> Kbuild does.
>
> Actually, those two variables are exported, as it appear in the next two
> lines. Exporting a variable with a dash doesn't work very well as shells
> may not be able to use them. When make find a variable with a dash in
> it in the environment, it unexport them.
>
> So, for those two variable, we need to avoid using a dash, so I think
> keeping the current name is better. (And now, I've find out that there's
> an issue in the build system, I'll prepare a patch.)
Oh, sure - if they have to be exported, the names should remain as they are.
Question of course why they need exporting when by the end of the conversion
you don't change directories anymore.
Jan
|
