[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V3 05/10] xen/arm: static memory initialization
- To: Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 21 Jul 2021 10:15:50 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1lnsFLGkSVQQ0HozFsqDtFwkQakqigH6bvo8zeWXz5k=; b=ZsItb/7GGGCB058BgKsFXgyj7Fny5REFaW1Oxi/zTl7zXDWLTwQKTzPpeim9YwjDBUS80tcR6c3/kuLvrOtz2vuzq+eC+atf0i7WqE10yn+lNH91Y020MNwRo5TgRYE3IVTm7keEIs8VNz1GKdKK3oEAE8GY8vs2iG1upoNhkhCsJAqVXrNZ8b3duHmuCi42oMQeGUNnIIgos672LlyLkQDCq/W4DYHQcqjsJAUcDjzmxsK2ZDaMd2rdN7cRsIIS1wj+ORvlTatNnqu9coTqo9JX4nlWRgfJx/wcJhAZT5KpuRwjGAhhgtsbLX1/GWKS0NsiVbp+oe9SKvvB1rhKuw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jIi4uy9u5DXmMeW2eabbiMMeD6P35VpxF7UPfmMkxvuKljyWB1ADrE3oFqaaEzsJnvNcGz9LsWRwLaSPxAYin0zobfBaCVE9/ZU6UjBlDU+khRMA3oe2hCbZVkF5LrFGSDZ4rlyWLbl5jTEICvApmxfitrpFvNnYVb36ZEBiIVXhjkXbrTUiV5cRg/rMNB184+Otd7P9CrsNiW6Kwoyn93ZNAFT5u5aS/ax6CuG6uc8Kic9GPHnhHBboTSfnMaSAc2jFOQ+eJLGZVEJhceJljNJgWID4VzsL8PilLjhYEqWOcyX2m9//wxQyX6e9klanusXLoFur5fySpHjY4hwqmw==
- Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, nd <nd@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- Delivery-date: Wed, 21 Jul 2021 08:16:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.07.2021 05:07, Penny Zheng wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: Monday, July 19, 2021 4:20 PM
>> To: Penny Zheng <Penny.Zheng@xxxxxxx>
>> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; Wei Chen
>> <Wei.Chen@xxxxxxx>; nd <nd@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
>> sstabellini@xxxxxxxxxx; julien@xxxxxxx
>> Subject: Re: [PATCH V3 05/10] xen/arm: static memory initialization
>>
>> On 15.07.2021 07:18, Penny Zheng wrote:
>>> v3 change:
>>> - include addition of CONFIG_STATIC_ALLOCATION in this commit, where
>>> it is firstly used and also change the name to CONFIG_STATIC_MEMORY
>>> - Fix TAB typo in Kconfig
>>
>> Not sure what this relates to, but ...
>>
>
> Before I was wrongly using " set tabstop=4 " for Kconfig file, so...
>
>>> --- a/xen/arch/arm/Kconfig
>>> +++ b/xen/arch/arm/Kconfig
>>> @@ -106,6 +106,9 @@ config TEE
>>>
>>> source "arch/arm/tee/Kconfig"
>>>
>>> +config STATIC_MEMORY
>>> + def_bool y
>>
>> ... this is (wrongly) using spaces for indentation.
>>
>> I also wonder about the placement: Shouldn't the option live in common code,
>> with Arm "select"ing it?
>>
>
> Sure, I will place it in xen/common/Kconfig, and add "depends on ARM".
But I didn't say to use "depends on", but "select". "depends on"
would be appropriate to use if the option had a prompt (i.e. if
one could also disable it on Arm).
Jan
|
