[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V6 24/24] xen/ioreq: Make the IOREQ feature selectable on Arm



On 29.01.2021 02:48, Oleksandr Tyshchenko wrote:
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -137,7 +137,13 @@ config HYPFS_CONFIG
>         want to hide the .config contents from dom0.
>  
>  config IOREQ_SERVER
> -     bool
> +     bool "IOREQ support (EXPERT)" if EXPERT && !X86
> +     default X86
> +     depends on HVM
> +     ---help---
> +       Enables generic mechanism for providing emulated devices to the 
> guests.
> +
> +       If unsure, say Y.

I would have given this my ack, if there wasn't this last line.
For an experimental feature, I think any uncertainty should
lead to a suggestion of turning it off, not on? Hence
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
only with this saying N instead of Y.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.