[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] libs/gnttab: implement on NetBSD


  • To: Manuel Bouyer <bouyer@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Thu, 28 Jan 2021 12:14:25 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oa240Lnfp/ltQ2I8Ds9sL3mxXzP7ps/H3ZJFxDyPERo=; b=GkoBMUl+Dgz3q5xXyavp916t/AdDHar2fI41am+8fkDh4wF0MTRmreF54Hx/fSrF2LiMWkO80KrFScrH2F4/9EVLLafRHsj+WfNtwrp0So6yJhqjcP2gApQoKAg7Gj2Dziwu/ZpBCJb0Z3wm42R0aciROAcHoCWKgCDQctOTKhMVQ93kmHjNIXFSXxBhFLruOs8mNaPQXDWJNrPaj9YY0OXHpXyXrnGRCP4xIOCM9kARgA3hVDicdW8kj55X1mcpXJWh9+xdoi3rcN4sT+m6xDr8v8s+m2wxQe8Lvl3AdS6C/owkeS6TMNoJHkmgEuS6la4/ckD8B8gd5OVKwhEkkQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xaj7qZu8HnLJsH3ZnwOG12M284TwX9e19GjzH+ng8LZpEIuXLm5dkWwxVI6mm4ZlEQGHhHQmf1Om7GLpa+to0e1L85SCbjRabFi+4z5D5XZGuPxkQ28iVFAfq6YnQLDNPQLVxfPsEuiiYHGfdei+e02oSDZo5t0b6QiZzzTwpKksqQ0ly1EYfjrVFdPsps2zk7mcbuaF749kU8DSi3Ar2U00eqpmihBqvliGPQyekHiUCIX3sjYcR6ZRX4g/lGh7QWM9vlSncOKy6EnfkacB3Cte7g0VPnAvSMqS50nFLH5fdTT8feqAsD4848foheiVTIcJNk0j3WysbhwbyoeaCA==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 28 Jan 2021 11:14:42 +0000
  • Ironport-sdr: nEyNvEUCYovYMRYN7Vu7U0oiCMkwCQdNP4IMYPEp1G80qkG308OMT42bKi2hdF/f6TzkfqCQ0r QgHn7lsa5lZXHmPHtDpmYDpLaqqJg/9FQh0nI+u3cF1y5qEj7pJS9M1WN8sg7REo5cXIDiwmsg vxN/4RFofU8VXYmRuZ3UwBcsz5AioQy3mmjEliVSfkGJKUTUZSnw5ZaRN1e4UXZb3odwEngbQG GSlWiG2ONziW7AIWXMhTtuFRN4kgAck15K3FSA1y72jXQTvrt32S+7t0Z+pzVP4feWGGlht4PE oRA=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jan 26, 2021 at 11:47:53PM +0100, Manuel Bouyer wrote:
> +int osdep_gntshr_unshare(xengntshr_handle *xgs,
> +                         void *start_address, uint32_t count)
> +{
> +    return munmap(start_address, count * PAGE_SIZE);
> +}
> +
> +/*
> + * The functions below are Linux-isms that will likely never be implemented
> + * on FreeBSD unless FreeBSD also implements something akin to Linux dmabuf.

You might want to s/FreeBSD/NetBSD/ in the line above.

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.