[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] libs/light: pass some infos to qemu
- To: Manuel Bouyer <bouyer@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 28 Jan 2021 12:08:02 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7PgsZaoWnAz+d/ukaybwjCFfqKuUkKYOqt1+K/9n7y8=; b=jy56piELvZveqY3fKunXVTtlUcqtkFte1LfKwq+FseTGZV1PJ03iB2Kn0oRw40j9PISTOLY6dlO6jWdqxLI9rA/3EurmwzOcZ1YzCBW+orhtbWDg8S5ht9So/NpdMKWe6c43WTiJx17LdiTaA4akCppqgnxu0kPZNTIxOaciYrc4kMHtXiWGVxflPn9g/PtH5kgpeKI+395eznU9RxrMsQixFeCIiYLaM9DKLzjkornJwZcMdTPJJ3orf4mVfH6agsCXSBFdh6RaZc+iAB72C/0AaFLX9ldEo6RnuojXvZRqnrKyNCFo8++OnDeKXtCel32t6ZtW704y0nffJrlqJw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W+eUXa2iQaR2nqNM5uP15LNgJUmXv/GF2ocbANdOsA4SVJUAQqhVUoZ4B2iq7A1rWbD2qNVi+TT2GntWDz8Fjcl9bDhSIof3o6G9IDcGjFoO3SDcj9n1iMQ/AQrEAKZLxZa3bSujmtwgb8xEAjyzNoebc3/GbTCxcbI3UK/6bz9IbtCxqedZcUzbLkHHnpQH+zTo1xisEbhI25c2XG6gSQH7h/e7vfKHnwyoj55djBryo4d4/wj0bsw9qOUbaw/SCfIOB9NEiAsKaYzX3nY+TW2f84mfNpsejyKahxrRw8w4dwmfyAX/w0BttRHO3BNjOliHYPOt/UYRxFW6P5GB0g==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Thu, 28 Jan 2021 11:08:25 +0000
- Ironport-sdr: LkcjW+hGT0xmfXTh8rcvE4uWW+Ejg5tfy7hJoQLqVuZH9OoUBPJQQq+BtfYc5bxKLGXSpcjfz6 tzh93tOVQLhi2pQ6SR//oL4JrBcUzxXFrq6K96TIgLWcSiuAczRgPjtlKaukacEnpJN3YCB0rq dqY4YyC7RIl3u461iNfmaCxNxN3JYa/mwPf2djunVykYUf6JFU7BSH4WBVzr50voi2vOSEBevx 2kuiGDNhAJNvTpE1Zh5thJWbwmWzkksmDw4tVkx6y8W89zD3XRhCSHnP+c7MAGxEU/6cupnT27 058=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jan 26, 2021 at 11:47:58PM +0100, Manuel Bouyer wrote:
> Pass bridge name to qemu as command line option
> When starting qemu, set an environnement variable XEN_DOMAIN_ID,
> to be used by qemu helper scripts
> The only functional difference of using the br parameter is that the
> bridge name gets passed to the QEMU script.
> NetBSD doesn't have the ioctl to rename network interfaces implemented, and
> thus cannot rename the interface from tapX to vifX.Y-emu. Only qemu knowns
> the tap interface name, so we need to use the qemu script from qemu itself.
>
> Signed-off-by: Manuel Bouyer <bouyer@xxxxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
If you have a moment might be worth adding a note in
xl-network-configuration.5.pod that NetBSD in HVM mode requires
bridged networking I think?
Also, the qemu-ifup script doesn't seem to be part of the NetBSD
scripts that are upstream, is this something carried by the NetBSD
package?
I certainly don't mind adding those extra parameters/env variables,
but might be nice to clarify the expectations, that can be done in a
separate patch.
Thanks, Roger.
|
