[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 0/6] x86/intr: HVM guest interrupt handling fixes/cleanup
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Date: Tue, 26 Jan 2021 14:45:15 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P/c+b3S0LGQkX6kBUON/6KhhOsUbKxaBEHggBbYMk9A=; b=PsgC2LfJkqHVCqCticp0CmbwsBTp90fg3Su0xubLqo2GFPlbpCyjvyhByKktt5mt94GoabIU1w3TZhdZdFipHCmVcCC+qCPiSFOn4Au5bljSB7iy12IlsbzbHidsf80rUtTdpff3vYYjsueMDtx2piJ2JllidiRnww581kXctVAIbP1Vr6/evVIiYUhJIdT9U/0G9b0+i3RvuadEq1Cn7a+mmvw0+ZRgZ1fZZsArdZtvZpejnCDtsSbRNeNk17QVnnoEg80VwA/ZAMN9E5WcTLZIssrAoEah/CamSqUtzdoJGKMygM8BHFHpd+sfu80NvUDy09P2jTOg26J47Q9QeQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jwup+EkFQevKWFB/Ow/pxgxrAyqvfhNVh5Vu/kAV20b9tn+AuGOodvB6p/UpS8q4/BingpnT6ejsCCZluV5wiDL0JIjIK1fiGfKxKwN+74XR4eXmnmm+geUkoUgqkPF1HA54ls7dCGRlVvDCXWqoc/Bmo2fibtRdg9q6aV2ubYSu0WBWrYtLufce4EtNSU4ya9G5JzdkKVUSiIwePAhwEQk+K1e6iP7Zo39xm3p978HHYoHyLnklWBCPHW49TdosHHWEb82T9GH9xV6qAHuEV9gMeon0QdFq55vqlrpDMnYkxKSe/CMrD9M2vfkNouQdYomi5zj6ShJSRlftdr+mWw==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Tue, 26 Jan 2021 13:46:11 +0000
- Ironport-sdr: sZgn3RhQ/trF7Sgc0Bd270VFLNw5syGxo9vL58/Fx8cDtveu8yVrLEENKK8oojfqjkR2MYMC1N FuhL2iCa4kSlamUUT1Jfr3FybpKL77pw17v6YrLRobVhypsCKC1gnOuzerCNr4aEUpcK3SjkSO 4dwc0Ov+hMAQ1CBqYSzE94RYUqs5LVIRuKeuhQFMUYYx5q3Vs5ShRs+kBWF5aI37C56ieto9jq UraXjQQCwxwJczO5B9vX5Dh0TWxkRuOlFFcTpgxnAFTRqL5e9iuYuwxFvI+99c4ifyFgXOgJ6z TmQ=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hello,
The following series aims to fix some shortcomings of guest interrupt
handling when using passthrough devices. The first 5 patches are
bugfixes or cleanups, which I think should solve the issue(s) that
caused the dpci EOI timer to be introduced. However neither me nor
others seem to be able to reproduce the original issue, so it's hard to
tell.
It's my opinion that we should remove the timer and see what explodes
(if anything). That's the only way we will be able to figure out what
the original issue was, and how to fix it without introducing yet
another per-guest-irq related timer.
Thanks, Roger.
Roger Pau Monne (6):
x86/vioapic: top word redir entry writes don't trigger interrupts
x86/vioapic: issue EOI to dpci when switching pin to edge trigger mode
x86/vpic: force int output to low when in init mode
x86/vpic: don't trigger unmask event until end of init
x86/vpic: issue dpci EOI for cleared pins at ICW1
x86/dpci: remove the dpci EOI timer
xen/arch/x86/hvm/vioapic.c | 19 ++++++
xen/arch/x86/hvm/vpic.c | 36 ++++++++--
xen/drivers/passthrough/vtd/x86/hvm.c | 3 -
xen/drivers/passthrough/x86/hvm.c | 95 +--------------------------
xen/include/asm-x86/hvm/irq.h | 3 -
xen/include/xen/iommu.h | 5 --
6 files changed, 52 insertions(+), 109 deletions(-)
--
2.29.2
|
