[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v10 01/11] docs / include: introduce a new framework for 'domain context' records



On 25.01.2021 19:18, Andrew Cooper wrote:
>> +enum {
>> +    DOMAIN_CONTEXT_END,
>> +    DOMAIN_CONTEXT_START,
>> +    /* New types go here */
>> +    DOMAIN_CONTEXT_NR_TYPES
>> +};
> 
> Does this enum ever end up in an API?
> 
> We might be ok as we're inside __XEN_TOOLS__, but enums normally cannot
> be used in ABI's because their size is implementation defined, and not
> always 4 bytes.

The only way to use this as a type (e.g. to declare a struct field)
would be via typeof(), which isn't something we'd allow in the
public interface (for being an extension). Hence without a tag I
would think an enum is fine to have here?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.