[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 01/11] docs / include: introduce a new framework for 'domain context' records
- To: Paul Durrant <paul@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 25 Jan 2021 18:18:51 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PGFGo1KxIoxCW18E+SphtbL6IWlYNvZiXZTy7Gbi/h0=; b=arx/bisTa8HqBhnk03lUloFyQf1QbPoyIgF9RN/Z8lscYZI7UTx8I6rAp7fV/3grfdEhPRBSPB2w3B2LxphrT34uB0UdpgMAPZOXSm67v0O7+W6f77OKem/oEeRNjWofbOH4T5TOCTNrnf9s+3qPWkaAnrkO59SXr1FaiuW21uGOVBFlzxeKm/9DeMOkyA+57uk7xcckf3T5FczmDJjJiDWkRWO4UDqz4B/WqfrV2kI4xxzWE3P5omyOLjYxbQffn9d6M1GYAAoVMyAWXySNma+rZZJSCFAyjT3w55FWc31QW09xKV1vth4NGN9UWFnF+5u8OUa2ukzBjryt6jzfDQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ky1o14Ng7PthXIr1XcYCQoDZ8cvrmwZB782za7jum6G8pjzxlbz3G6WgXxJWcDUm6Mgcl9Q4/aAasUI0wnylhIMl1nVosBz//Rx7yPx4zMNKBM0CZRo3FWeXaF7DmB7+jiVY0NfVbCMc5mRoNer57oz4d7TCbTxlurSgsIaO1cemeUlyIvCDCbnbFp1fgpUlHFs1IU81a4bYuEyVSi84Lduafg6ZEHo/ocx8ZRRpfP7y8S0+jvViOcKTI3UpXBaZIzNUjpbKxFO9zz/a8qM7dxsWXa6CrPPqvij7TSJFjR/kOHsJM8f0IXhhSAdgcIoeLwmAKUKV7tLLLJZjfKeZ9w==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Paul Durrant <pdurrant@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 25 Jan 2021 18:19:06 +0000
- Ironport-sdr: U+hDOsSWnuC95b4vljd5ohCvrhmorFCFcVPflfwXsXJG+yPaI6+tQ6WS97oTq6VtAoXD4kaJOX FJcrSFLPiQOz6q5RC4FFBPILEWnzURtFTERZb8VnUa89gQtSmbH+1HBAmDxuHiqFzFiOLFX2h2 dwr59DhB/Ox1WGM7QN360J9uLxUFdJ36nkt8d9l8GPJDRZlBR1md8X7nnxyk+ks/pE5+TTI+SX /47h+jJ2p5/Q87EC/QRbbaV2ORDgUVKwC4Tz3GDwwWCXCeL1fiDIMaOJybP5MKZ3qHzumEq3XJ aVk=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/10/2020 19:57, Paul Durrant wrote:
> diff --git a/xen/include/public/save.h b/xen/include/public/save.h
> new file mode 100644
> index 0000000000..c4be9f570c
> --- /dev/null
> +++ b/xen/include/public/save.h
> @@ -0,0 +1,66 @@
> +/*
> + * save.h
> + *
> + * Structure definitions for common PV/HVM domain state that is held by Xen.
What exactly is, and is not in scope, for this new stream? The PV above
I think refers to "paravirtual state", not PV guests.
> +#define _DOMAIN_CONTEXT_RECORD_ALIGN 3
> +#define DOMAIN_CONTEXT_RECORD_ALIGN (1U << _DOMAIN_CONTEXT_RECORD_ALIGN)
Do we need the logarithm version?
> +
> +enum {
> + DOMAIN_CONTEXT_END,
> + DOMAIN_CONTEXT_START,
> + /* New types go here */
> + DOMAIN_CONTEXT_NR_TYPES
> +};
Does this enum ever end up in an API?
We might be ok as we're inside __XEN_TOOLS__, but enums normally cannot
be used in ABI's because their size is implementation defined, and not
always 4 bytes.
~Andrew
|
