[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 15/17] x86/shadow: drop SH_type_l2h_pae_shadow
On 22.01.2021 21:02, Tim Deegan wrote: > At 17:31 +0100 on 22 Jan (1611336662), Jan Beulich wrote: >> Because of this having been benign (due to none of the callback >> tables specifying non-NULL entries there), wouldn't it make >> sense to dimension the tables by SH_type_max_shadow + 1 only? >> Or would you consider this too risky? > > Yes, I think that would be fine, also changing '<= 15' to > '<= SH_type_max_shadow'. Maybe add a matching > ASSERT(t <= SH_type_max_shadow) in shadow_hash_insert as well? The latter (also for shadow_hash_delete()) would seem kind of orthogonal to me, but for now I've put it in there. Jan
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |