[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [OSSTEST PATCH 7/7] make-flight: Stripy xenstored


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 22 Jan 2021 16:36:14 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PiRISvG1GyN74JUp9mNR4Ao8Igdw8U1WuloGCuEXztE=; b=TnnLf3PSII+w14NK5c2TikKTbf3zYn6uxKdbQ4iqpCvieQG+igGntHryBzK2zm5P2085Q70RJ816mlzWCvqjVpo+cMZCuWJZXLQDn8nnHb4tf+W3BXxKmLeLmjBKqYQ+PFw3iKxO5dwCo15EeCk1nFogDrYG4pBCYs/Gr3Pc9zKuKOHXzMYKUbN2eudk/gpymsYzOqkUkH/LYy8qFDVaLtHJiFYKtZLYWI+8b/+nCxDHj9wMcsL+Xzkk0FSx2Rb513o1VrOz2y3rJjY7emExhMG+oe7DLL0tr1K6Ys4y+nab6a5MrD6A9FxxdNKRSYJAhRDjNm2gJ5aR05inyWcPag==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fLxYy/mDdTI3rvMqJdkw41UqAdKTaa6f3VYuSIWC8QL6bh4u3iMa+N5AX4IfN8KOhyE8lOPfpi43xfV6DqQoVODDZ5UDSbwuuniUt9yi4mgGPZwDpGRgf7xm4HMJWLkq/Mw3YgYCRC8B1p9CZl7VpyFu75Hs9dVK6d7gpL4JGqP6y8zqtr7MM5lySnZPNiEwvzlJowGv2vTKTBQjzrE02oeyhVWsvpWPOWDayHvy5T/PgpaV4Tqn8uq3+08P9WxNFwaJfrDWc7eHyzoIaxd9zTuDHq7HN3qbx700dcJtsxGXMSZcoIx+ersgqB2B/WaEk/ueZC8/cMMNNzheayfJtQ==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Edwin Török <edvin.torok@xxxxxxxxxx>, "Christian Lindig" <christian.lindig@xxxxxxxxxx>, Jürgen Groß <jgross@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 22 Jan 2021 16:36:30 +0000
  • Ironport-sdr: XWDC93QusmamUFBWr0A/9ITmbb5kGeKvo6f0L0Qf8eTuSE1xr2wi6BLmNbHoadc63IZ1EFpIFh IqvJvGtZrDBBDmAB4HHCZ7mdoevWM3SgqcZbte1sW+rg9kA+1vgAeDFjawV63fs7hPJ/cbz5An MSdOOuv9+ltYgbaxBeFJQVCKV/hs0yU5Gln8mbAFotSEa32UkRv9IfOdLzRuNqjXuFVpSwT9Nr vuxpRDq9NadYuto+tG0GLK61r4gvVQF3Mlav8ELtmYZqr+suh43P3CF68ACPuAldyiS9gQybNe iAs=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22/01/2021 15:56, Ian Jackson wrote:
> diff --git a/mfi-common b/mfi-common
> index 35efd233..2834411f 100644
> --- a/mfi-common
> +++ b/mfi-common
> @@ -509,6 +509,13 @@ job_create_test () {
>    xenbuildjob="${bfi}build-$xenarch$xsm_suffix"
>    buildjob="${bfi}build-$dom0arch$xsm_suffix"
>  
> +  local xenstored="$xenstored"
> +  if [ "$xenstored" = "" ]; then
> +    stripy_rand "$job 2" xenstored  xenstored oxenstored
> +    # Without " <n>", all XTF jobs use oxenstored
> +    # With " 1", All OVMF tests use xenstored
> +  fi

An extra thought.  What exactly feeds into the decision?

If it includes the flight number, then the retest logic is going to get
very confused on xenstored bugs when the implementation change between
the two runs.

Also, what is the bisector going across this changeset?

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.