[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [OSSTEST PATCH 7/7] make-flight: Stripy xenstored


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Christian Lindig <christian.lindig@xxxxxxxxxx>
  • Date: Fri, 22 Jan 2021 16:11:44 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c8v2hNjW/DwGAOiS6xZJlTgwoULslzdn9Zop57gyJPA=; b=W2BtpQQSHmGtJngu3cVPtfgY/NRZ5AK/Wo9ut4xQl6tK5B1Vt397290UIL9+ZdoBTg/Z1JqPGnOJ4UnEjSwHQlyjaKnQvwSzOJR9rBRL+dZjYKjh0SeD7ww4ghN69TB1V2/tO5d9in/nPNEKFD9LCO+IUgROj4ykFmI7z5qzDvquS+WOVA24we47AdD8886yOVoqCNLu4NwQkUOESi2gZT/ZsgE4LyXCLXMJpYaeGFlgrtRsuqDknoHjaVduEwOKb0ldu3hbffrFAtdNqxNseBwM1ZRXmqOUyoHaaUrDnGMgcW4xGMRcCiCYfh9sV+FPO/WhC+CJnQDPmXZl7DX6mg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ynu1NNa0+5LZVT0F3SRJBQ0hN2m9Jp6oSDWXgwhLcRJ6rEgXSkWaNxVAwrqUHIwoSXSTZMS68gNGeNR2TXkVD30MVDgR8p9WdVQNWpfmGuGwHCRoX4lbFFXgmfLA6VPsyc6krJR/6Uttjbw3GdXNAr4ASRKbdfwyGApdhsS0EGmHMFibwpKvzN92T2RArw8xnKgvzCJYQt1fzMdaNSwIssRZQqBEWZVe3gUWhXBplDHcArrSAGG406QSXQh4lCaRzBIGgRDhDrsm5zhF6aYylFwvPKZ9DZwoTF1+vYIjgW0R3rM7TwhWPL2mjdgcASwa7S6ixLTF5U5SqWXPEj1wQQ==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Edwin Torok <edvin.torok@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Jürgen Groß <jgross@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>
  • Delivery-date: Fri, 22 Jan 2021 16:11:53 +0000
  • Ironport-sdr: rCUIUpG3vKB1+g1FjWEZmcq0AsR/qw9VUM8p41JJYAWtGwPAXS2op1McoIoZxN7Bi6wARv10IW Z9arKElygLs6CgTzMwfuv+o7QDIqDQR73qu7K72i/ie+Hi0NJzqZbAncMHtdtad2cW6ulY5U0v 3iYXhVwh1+m2pE0aiY0We2a6oIh27kqc60bhf+vyzr1nrVu10gyp+/6ULsrhU6xq8XHMTP73O5 +lxaeOorxSvh304MBtD5WmY763Iq8A0IjxGAR/XQU2QUaFWuMNVX451KfRSC+/VCxirERXmnyK Yr8=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHW8Nc+QBwVu/ASVEKuol5FG3gZMKoz0KTB
  • Thread-topic: [OSSTEST PATCH 7/7] make-flight: Stripy xenstored

> Change this, by selecting between C xenstored and Ocaml xenstored
"at random"

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>

________________________________________
From: Ian Jackson <iwj@xxxxxxxxxxxxxx>
Sent: 22 January 2021 15:56
To: xen-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Ian Jackson; Edwin Torok; Christian Lindig; Andrew Cooper; Jürgen Groß; Wei 
Liu; Ian Jackson
Subject: [OSSTEST PATCH 7/7] make-flight: Stripy xenstored

Previously, we let the Xen build system and startup scripts choose
which xenstored to use.  Before we upgraded to Debian buster, that
gave us C xentored tests on ARM.  Since then, armhf and arm64 have
both had enough ocaml support and we haven't been testing C xenstored
at all !

Change this, by selecting between C xenstored and Ocaml xenstored
"at random".  Actually, this is based on the job name.  So the same
job in different branches will use the same xenstored - which helps
avoid confusion.

I have diffed the output of standalone-generate-dump-flight-runvars.
As expected, this addes a variable all_host_xenstored to every job.

To make sure we have enough diversity, I eyeballed the results.  In
particular:
  * The smoke tests now have 2 C and 2 Ocaml, one of each on
    ARM and x86.
  * XTF tests have 2 oxenstored and 3 C xenstored.
  * The ovmf flight has one of each
  * The seabios and libvirt flights look reasonably mixed.

Most other flights have enough jobs that I think things are diverse
enough without looking at them all in detail.

I think this lack of testing needs fixing for the Xen 4.15 release.
So after review I intend to push this to osstest pretest, and may
force push it even if shows regressions.

CC: Edwin Török <edvin.torok@xxxxxxxxxx>
CC: Christian Lindig <christian.lindig@xxxxxxxxxx>
CC: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
CC: Jürgen Groß <jgross@xxxxxxxx>
CC: Wei Liu <wl@xxxxxxx>
Signed-off-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
Release-Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 mfi-common | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/mfi-common b/mfi-common
index 35efd233..2834411f 100644
--- a/mfi-common
+++ b/mfi-common
@@ -509,6 +509,13 @@ job_create_test () {
   xenbuildjob="${bfi}build-$xenarch$xsm_suffix"
   buildjob="${bfi}build-$dom0arch$xsm_suffix"

+  local xenstored="$xenstored"
+  if [ "$xenstored" = "" ]; then
+    stripy_rand "$job 2" xenstored  xenstored oxenstored
+    # Without " <n>", all XTF jobs use oxenstored
+    # With " 1", All OVMF tests use xenstored
+  fi
+
   job_create_test_filter_callback \
     "$job" "$recipe" "$toolstack" "$xenarch" "$dom0arch" "$@" || return 0

@@ -529,7 +536,8 @@ job_create_test () {

   ./cs-job-create $flight $job $recipe toolstack=$toolstack       \
     $RUNVARS $TEST_RUNVARS $global_runvars $most_runvars          \
-    xenbuildjob=$xenbuildjob buildjob=$buildjob $tsbuildjob "$@"
+    xenbuildjob=$xenbuildjob buildjob=$buildjob                   \
+    all_host_xenstored=$xenstored $tsbuildjob "$@"
 }

 usual_debianhvm_image () {
--
2.20.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.