[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 20 Jan 2021 15:44:25 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y1eaplPOBbaDwYza/bZPFcOcVO9nnrVVB4KKQ/vU1yQ=; b=hKiypgOf42NMxH7ceCT7ksD4lJyb83Y82SQmDNksB5s1nLpEzmmKlTOKLYj2LgQ5jtz1XDyOEiWUU6AAhXKLo5FSR8HkNaBpXFg2w7jiiEPgRjdiVqkyzpgkuEDdGpxA3+T84NEEn3x54BKLQLmBtfU0acTXQNS51W6KWCZuWrk5vZuCIMRhCmIQeIHdNCX0FestNyYewXdWwdRwAJbi5BQEAtJs9QCr/6JW8WgsFNPT5xBTMIc80tcxk1upono2aSBBqTrZqCPc8/eiRxnFCWheRxOdK5csW8i4UKWUk3Y0bkKEVtD3+mss3lXLB/GJ6wLCqMjZLP+c0LLYnw+BAA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QDDD/7tEGheX87KBy8mRzWM4YhNZ4Oi6zo54EeuYOjbag9Uo7eBoHn6Qsyz3YFA8VqsvyDz6URlLNjrQN2Tv9SUzoEBnfdjKd/OWZxEB7VRjDAegzYnYzgu2eU6dp6UeKg1IProfC6jiPaniYwUIf7kjgnByR44XkjVjVO7uZg2Omhkaj4t2fQsuXOBTvlMcC6zOmO7Lsfd+OzyVkw90F6CqULhh+MtNnsrPPONk0mpZDvbmfwH2UEZqfLVrXcA1EF2vmShsahpO2ytJuDf21LEYiDfcfb86osf7G8az/bXH6D1B1Wzn880FMtgH32TACilQ2Iwlw6TrFxgvBNvdCw==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <linux-kernel@xxxxxxxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <linux-block@xxxxxxxxxxxxxxx>, Arthur Borsboom <arthurborsboom@xxxxxxxxx>
  • Delivery-date: Wed, 20 Jan 2021 14:44:43 +0000
  • Ironport-hdrordr: A9a23:QZafPq1fnuTI6ZUEQ37v+gqjBW96eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/FIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmtJ1/Z xLN5JzANiYNzVHpO7n/Qi1FMshytGb8KauwdzT1WtpUBsCUcBdxi1SYzzrdXFebg9AGJY/Cd 6w5tBfoSChZHQQaa2AdwM4dsLEoMDGk4+jXAUPAAQp5BLLoTSj7rP7FBbw5GZibxpkx7A+/W /Z1zHo/6nLiYDB9jbw9U/2q65Xltzo18dZCKW35PQ9Bz3whm+TFeZccpKYujRdmpDL1H8Ll5 32rw4kL4BP7RrqDx2IiD/M/yWl7zo08X/lzjaj8AveiOj0XigzBcYEpa8xSGqh12MasNtx0L 1G0gui3vI9Z3Ow/1WO2/HyWx5njUayq3Y5+NRj90B3aocCdKRX6bUW4UI9KuZwIAvB9IslHO NyZfusgsp+TFXyVQG8gkBfhPaoXng1Ay6cRFkDtsG/w1Ft7Q5E5npd68oFknga8pUhD7FC+u TfK6xt0IpDV8kMcMtGdao8aPryLlaIbQPHMWqUL1iiPKYbO0jVo5qyxLku/umldLEB0ZNaou WMbHpo8UoJP27+A8yH25NGtjrXRn+mYDjrwsZCo7Bkp7zVXtPQQGy+YWFrt/Hlj+QUA8XdVf r2EolRGeXfIWznHpsM9xHiWqNVNWIVXKQuy5gGcmPLhviOBpzht+TdfvqWDqHqCywYVmT2BW ZGcyP0IOlG80C3Sl71iBXcQBrWCw/C1KM1NJKf0/kYyYALOIEJmBMSk06F6saCLiAHkqFeRj o9HJrX1oeA4UWm92fB6GtkfjBHCFxO3bnmW3RW4SsDM0b+d6c/q8ySEFoimUevF1tadYf7AQ Rfr1N49eacNJqL3x0vDNqhLya8g2YMommJC7MRgLeK68ugWp5QNOdoZIVBUSHwUzBlkwdjr2 lOLCUeQFXEKz/ogaK5yLoOBO/ecNF4qByxIdFdrE/esUn0n7BuelIrGxqVFeKHiwcnQDRZwn dr9bUEvbaGkTGzbVckjP8AK11KYmSPCLdgBACIDb8k3ozDSUVVdyOnlDaagxY8di7P+18Jjm LsFyGSZMrGG0FQoHxez6bs/m5lb2n1RTMCVllK9alGUUjWsHd61uGGIpC+1GaccXMu6OAQOj OtW0pbHipeg/SMkDKFkjeLEnsrgqg0NuvGFbI5bvX4wXW2MrCFkqkAAt5Z9JtoL8rVr+cOSO 6TEjXlaw/QOqcM4UiyqXkkMiUv9yVhvvPsxRH/7G+3mFQ4GuHfJVx6R7cdZ/GQhlKUM8qg4d Fct5YSu+D1D0DaLvih4ovTZyRYKhzSrXWtJttY4Kx8jOYXjv9LA5LfUTH0z3lJ0xU1EdfsmC olMdFGyYGEHrUqQtcbdC1Y9Gc4jdijLEMktQrtH+81FGtd+EPzDpes47DSr6AoDVDEjAzsOU OH+yk1xYaPYwKzkZobAbk3O2JYdQwV72lj5vqLc8n1BB+xf+9OuHq8PXnVSs4WdIG1XZERpA 19+deGgqu+cDf5whnZuX9DGZ11mlzXN/+aMUarAu5H89uzJFSKjO+L2aeI/UjKYAr+TV8Zi4 1DfVEXdeJZhFAZ/csK7gG2QJr2r1NNrnJX+jsinkLx24Sg/WfQFVxHNwqcmZlNQTxPKBGz4v jt+fOTkHDw+iJM15WGDkdfedlSB8MdJ7KaEw5nMsJVprKh+sMU7xhraAsyDmI6lTD21/5n27 D8w/nJR+j+Ex7TWG4p8zQtPP8SogUgr2Zcf8+iqZ+8eBwQDO4UA/05j7om6g5BoF718lEacl FxrQQuzI7ANRjqOH57GKjok+LN8WUljaKF7EBjo2gVh0O/hDinyiPItsu8pnZclRy+kiZrq6 WYACEwjiFQqxJ9zcVaXEalXnXrRRq+QTbK5asufWZoEGU+j/gs5SCzU5Ujkpyl1WJroXA6D0 ELssiWP2LeTTnXCtHqNjCtE72Oca5PSu1cMGYCMHK6XS6s8v9bLmOqCaVc/w6hlXsUCa+FNr nOWnPkMLAX8LENIKupWoaChK71p3lk3msPpIH2g2HtpoMN0eqHIGdHwLYAWrksMAKr8CBky8 CUTALCMoMGiRul0VDJ+GBWIsQbzB8SxlRfrSAMGDmwD9f2XU15oiUaoqWZCREw2IKESdxPt3 3GrkPksH7KNBqMOE3EYcxH31s5sALASpndpV60Zv74MA1T4uilFeO8mTDh3wHX49WHgz+2jG Im7UpMARE0wRySRtIfFjPfyF0bKQNlEld0ixW5s5BtlEdPlAshaHgcVcMD9CLmBVTVCDDlni 3ZIX91+5scW2F4iOBVtxNz8w4fsU5RSa45moSEqV+reGsBRB1L3cAKhwyHk9F4X2hiOkfqWd CE+eSDMoCvxNNXDjqc5vIKILlycSJUk6/Y4+HZVGZKcxmYx7FO1hDHkytMoWQLiosgrgXtkY HYdj/87PtirageT7L4gSg1U7JXY997o3uSANdR974tik7khvKtmB4Hd+Ozul1FECyrW9lNdF U8dnGJne9r2seKvWWbf/tS1/z7+DR+beyTOWc1/Ij0I3oH6L4w2s/OaIPHOSGQrMFOCeIdxw rU9EhW8RuopazrT4WmdxOphjeSS2EqTIxVGlZtB+3dTJ9k+rcngwRa0+skOA1em/pxZm2GoP 830njDrZgZpZtorFBSWYuX+1wr8yl3D+eBvIAt3G6Yzn0jlP/EiqYvtLCsE6gIJk6BCvRLUb MxndXzXPOZMlveFDBsnIURek2bGCSVyRd61bQveS4bgKd+KuU0+Yhbs5BkvwOpFR6MJm40cr v7NIh6+aMHHd6m2RU6WSuTyv2uaBwg3JA5+DQkOcsnruniZr0lnzMBor1KgvazusYoeMUQkJ K4LRP2pHLCvmnXUBmUM9qXR0F9e2x3CxaxsDy9MlWzDzvEn5g+x1hBtD0vDXva/9+wjWvhZ6 z0mHcO3jvfcCZA+MqJru9lzkSYrAWa6asPWbaQYuj0W+G66W8HgNx8m62ZwpLAmq6HH65Iwt FwsrN+a+s3l3rv5r7lUOBDkEqAFMQq5eQ+CFfw+ycgs9WM7tLuIbqg1ix2+62BoUyKCcD7OD vCe+YUBI+YU11qdTUYZvQlvTZIclscnxeCWTRgYU/K9b6QE7U/bVvBJSMkTMi5SHGdVqgTQV WC6MDIaZjIWtZfAjRMHmbwWq+b2quxtFKlPVfzAEbvmmxbLgqt5AuCya/S3g==
  • Ironport-sdr: aolyax8z7ddkC2NBOrWWP7fk5u91dmv/GiOu6ZpP4vSQNuMLY0RGvseSTUga6C7OWKsKrK+pqZ Tq0BmXosM0HgA976gdLnH5vd6D5Wg05jpxOuoFpYGgQYBoPKvxfQbF0ssgNZVNMEnY3Fhq7tHx qC9fwK6JtpMoXgOeEZNAqR26vNmtx9QM487Or/nFy/6lnkb0xHFwNqHJLRO/6PmJGel91iDUue mzXm4ylt6u/Th1970GqqlcL0vF2Ab85OnE+Zm2/3aOXkSouSU2b6N26y6GY+Ufgymbs9Orhw0a QAs=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Jan 20, 2021 at 03:37:57PM +0100, Jan Beulich wrote:
> On 20.01.2021 15:35, Roger Pau Monné wrote:
> > On Wed, Jan 20, 2021 at 03:23:30PM +0100, Arthur Borsboom wrote:
> >> Hi Roger,
> >>
> >> I have set up a test environment based on Linux 5.11.0-rc4.
> >> The patch did not apply clean, so I copied/pasted the patch manually.
> >>
> >> Without the patch the call trace (as reported) is visible in dmesg.
> >> With the patch the call trace in dmesg is gone, but ... (there is always a
> >> but) ...
> >>
> >> Now the discard action returns the following.
> >>
> >> [arthur@test-arch ~]$ sudo fstrim -v /
> >> fstrim: /: the discard operation is not supported
> >>
> >> It might be correct, but of course I was hoping the Xen VM guest would pass
> >> on the discard request to the block device in the Xen VM host, which is a
> >> disk partition.
> >> Any suggestions?
> > 
> > Hm, that's not what I did see on my testing, the operation worked OK,
> > and that's what I would expect to happen in your case also, since I
> > know the xenstore keys.
> 
> Does discard work on partitions (and not just on entire disks)?
> It's been a while since I last had anything to do with this code,
> so I may well misremember.

The command provided did work for me, ie:

# fstrim -v /
/: 19.8 GiB (21190717440 bytes) trimmed

AFAICT the blkif discard interface we provide operates at physical
block granularity, so it's possible to discard a single block, and
hence should work against partitions.

Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.