[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional


  • To: Arthur Borsboom <arthurborsboom@xxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 20 Jan 2021 15:35:15 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OyOR7ooZfZSJYzcB6XtiZ+6cs/eR8SAObO2ckkyoKho=; b=RYwRchN0WCQgBEpK2nWvkliyfQL2fu8rWS1RksmHBrOH0tYuIc1X6sWz3k5ZyiaZY0Ukp4Lns04x5wn6OLaC7QXfpcQnUPFu0c6hUHZE8yz26cENdvFG9zvqyEa81g/7HWklhvgVWkG64yLaKGIMaxWlarSC8CjbdFORXYVSiYPOC7JTHv4/F1Drs0KaZG8SqNS63tfrPqOCIs8ruGnDVaZrBmBj2sqn17uW47xeo5TBo9BE7zXNx1Rp06NfkI8cMfP6defAO+LzKPi4XTYgxnvpra6+YT98DL9Uq0/O6nTMAcHPCbI6iRUlQx2Wg2gEyyWbwyx79n/C4yG14Vz2qg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SWfMhVOSSlC94xfH4FdDG9se/uvHtykqRIb1Bw3TYc2gxlLz1e6oLRaLe2+ORSP6MumfsEbWT0NTtfCtMU5Ds7mn7mp6zvrCe1w+ObmgH1zJDMYJYJFy2TLDkYm4g94BscrX43wO0ez/pcJq4jl4e0rvcCdEpsOxGVqmwQ7AQRzBn4wJYmEPXw3aN6tyJD9Ht6UGmfXAl3GHzpKTfrKsemT1QjwzIgS3JtxpbUEN0+ELw3pj3eGSgv2MoWbyQwAjr6awBrysVGsBtO3kb3IcSK9uxn6IbPsCSgX+KE3U8vJ3HADVve6WSNnnCRhzN8Ng0O6jeAzQxitK2sjSQUFQvw==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <linux-kernel@xxxxxxxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <linux-block@xxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 20 Jan 2021 14:35:35 +0000
  • Ironport-hdrordr: A9a23:cm5uFa+jVdm4js+ex1Juk+EJfb1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmzybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIULD38Zn/+ Nbf6B6YeedMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsLV4hLxW5Ce2CmO2dxQxRLAod8OZ qH/8xcpyehf3N/VLXHOlAuWe/fq9rX0K/8aRkdCBI9rCWIhzWk6Ln1eiLoois2eTVJ3Lsk7C z5gxX0j5/Tyc2T5z398yvo75pQkMb80dcrPq2xo+UcNzmEsHfMWK1PQLuH1QpFxN2HyFFvq9 XUpgdlAsIb0QKvQkiQgT/Anzbtyywv7XiK8y7qvVLGrdbiTDw3T+pt7LgpCifx0EYrsNFi3K 8j5Qvw3PA7fHCw/lWJ2/HyWx5njUayq3Y5+NRj9EB3aocCdKRX6bUW4UI9KuZxIAvB9IslHO NyZfusncp+TFXyVQG/gkBfhPaoXng1Ay6cRFkDtsG/w1Ft7QFE5npd68oFknga8pUhD7FC+u TfK6xt0IpDV8kMcMtGdas8aPryLlaIbQPHMWqUL1iiPKYbO0jVo5qyxLku/umldLEB0ZNaou WPbHpo8UoJP27+A8yH25NGtjrXRn+mYDjrwsZCo7Bkp7zVXtPQQG2+YWFrt/Hlj+QUA8XdVf r2EolRGeXfIWznHpsM9xHiWqNVNWIVXKQuy5cGcmPLhviOBpzht+TdfvqWDqHqCywYVmT2BW ZGcyP0IOlG80C3Sl71iBXcQBrWCw7C1KM1NJKf0/kYyYALOIEJmBMSk06F6saCLiAHkqFeRj o6HJrX1oeA4UWm92fB6GtkfjBHCFxO3bnmW3RW4SsDM0b+d6c/q8ySEFoimEevF1tadYf7AQ Rfr1N49eacNJqL3x0vDNqhLya8g2YMommJC7MRgLeK68ugWp5QNOdpZIVBUSHwUzBlkwdjr2 lOLCUeQFXEKz/ogaK5yLoOBO/ecNF4qByxIdFdrE/esUn0n7BtelIrGxqVFeKHiwcnQDRZwn dr9bUEvbaGkTGzbVckjP8AK11KYmSPCLdgBACIDb8k3YzDSUVVdyOnlDaagxY8di7P+18Jjm LsFyGSZMrGG0FQoHxez6bs/m5lb2n1RTMDVllK9alGUUjWsHd61uGGIpC+1GaccXMu6OAQOj OtW0pYHipeg/SMkDKFkjeLEnsrgqg0NuvGFbI5bvX4wXW2MrCFkqkAAt5Z9JtoL8rVr+cOSO 6TEjXlag/QOqcM4UiyqXkkMiUv9yVhvvPsxRH/7G+3mFQ4GuHfJVx6R7cdZ/GQhlKUMMqg4d Fct5YSu+D1D0DaLvih4ovTZyRYKhzSrXWtJttY4ax8jOYXjv9LA5LfUTH0z3lJ0xU1EdfsmC olMdBGyYGEHrUqQtcbdC1Y9Gc4jdijLEMktQrtH+81FGtd+UPzDpes47DSr6AoDVDEjAzsOU OH+yk1xYaOYwKzkZobAbk3O2JYdQwV72lj5vqLc8n1BB+xf+9OuHq8PXnVSs4RdIG1XZERpA 19+deGgqu+cDf5whnZuX9DGZ11mlzXCP+aMUarAu5H89uzJFSKjO+L2aeI/UnKYAr+TV8Zi4 1DfVEXdeJZhFAZ/dQK7gG2QJr2r1NNrnJX+jsinkLx24Sg/WfQFVxHNwqcmZlNQTxPKBGz4/ jt+fOTkHDw+iJM15WGDkdfedlSB8MdJ7KZEw5nMsJVprKh+sMU7hhraAsyDmI6lTD21/5n27 D8w/nJR+j+Ex7TWW4p8zQtPP8TogUgr2Zcf8+iqZ+8eBwQDO4UA/05j7om7Q5BoF718lEacl FxrQQuzI7ANRjqOH57GKjok+LN8WQljaKF7EBjo2gVh0O/hDinyiLItsu8pnZclRy5kiZrq6 WYACEwjiFQqxJ9zcVaU0alXnXrRRq+QTfK5asufWZoEGU+j/gs5SCzUJUjkpyl1WJroXA6D0 ELssmWP2LeTTnXCtHqNjCtE72Oca1PSu1cMGYCMHK6XS6s8v9bI2OqCbURoymEgXsACbODPa mremumfeIw1bcdJrD2RMqGjdrOvzIph006tZ7xinCOgZtRnLqmDxN72OhNFJRBK0Oh+Sd11c aLRgTfP4Qb6zG9lR2R1Q1IYNAR2Agb2k8cuGMZHz6pHcq6QgV7qCcB0IKBflxV9e+RDdJUu3 zGu1ivpT3fMx2VKlClX9Q2kjgU3ReERILRpF6hfbXtcxhU5fG3CK+80S73zRXTqdnEjD7QsH pWoC5hbARwzweeR9IKDXjKi0gcLhp3Dxtp1BO4xbB12AovuWY0NjgKAMUT9iTgDh7RSyXimT TLPDN1s4UKSXV8i+RFt2dB63hS12M8XPB5jNGCuV2tfmBLQkJH3NwNkRaDk8Q7SjB3J1LxOP CcgqnqH+26mpNBWzyM5PQMK/N0Li5Vj6jO+eXZQSVfKwyFwLZIywbQ8B1U1Sljp+Y18EX7xI fIdDn657Fk8qQfU7Xumyw1RvFFPNZkqXiDB9dB66Iki0ry49O14VNsWo6m5B1TRSq7Wd9Lfx 86KX2Igeh9wMOKqCaGNpJlz4S2lBkTeLLTLzIz7IryJXFN7uE829PJfpnDOTTTtY1KBOke3R HV8FQmxwPX6MHGIpD4NwX8gCeQTWchBooKFldxAPvHSJ9xua1vmRZB1u97PkVAjehlYieK6Z YAyg2OyrV0sMUougVUSYmR/Vdh9XZ7DvuGqpop3Hvb1SIlgf/NgqQvqqO3F6ASM0uYBpl9Sc l89/ieSa3ZJA7YBDJqmo5bfBKXGTiS3w1+1aFseHALgbJ+M/k+/ptTr59pvAfEIwbyawAZH6 6ldJ4v/7MFG9itkx1yRz2B3vm6aAExwIE77yElOdY2qfPsfKMhg0M3uvQH2dver5hobpAWgJ C+Kxi8sjrfv2LBVA+WP9ycSSJFYx46aTvcpWL9JAC1HznCmZN01gdUqC8xEXnBoMjvgWr9YL runHcb2CrWcSJW7suOvPZ0xlD9mx3npMQiNKPOIvS/Uu6/5T9Uhscv36eEy5TMhqDEG+xZ38 Zutqt2cOx1kDOG0aarHb5u/V/eVNho6KYoSUCx92Utv9uO8cD0NLqjzToE27Xy7C2nZNWleD iaaf8fC5KJRkltejAFfPA5zQBQPRZBsnqXB3RnPlre8rGVDq87cU/NIC0rRNWiUmb0ZrBeDA qvhdeXb43IU95FCi5CXWitM4yDn+bmmT+yYlHmAE/ngGJdLgqllj+ateK33vPe
  • Ironport-sdr: zJG8FlYCzwhLOj8dzfvjhcRGXcFbufTeujyFcCsuWU5YAUdxaPtzV2sqItIUtfp4g7Y6zslV1R JVpMZrA6MLk8hvLDuuZRUlP3ji0eY+qq89CShv+ocKQ1MPL1NA8deSgiEvvDxb1Jzwqn338m8X YoIOyN7QxmyjWdqgTNaT5Rr43zd6uvqg0UB4xCpSJxJvRONmTZWNiPQItFhAPwA2oTfiChgchh n0KwE2L3m3kfeY/QoCaKuay1fQAbZo2GWe9L1br7Chbfcyucrsd0bj1ZuJqB5PSQ66eRQUKnU1 M8g=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Jan 20, 2021 at 03:23:30PM +0100, Arthur Borsboom wrote:
> Hi Roger,
> 
> I have set up a test environment based on Linux 5.11.0-rc4.
> The patch did not apply clean, so I copied/pasted the patch manually.
> 
> Without the patch the call trace (as reported) is visible in dmesg.
> With the patch the call trace in dmesg is gone, but ... (there is always a
> but) ...
> 
> Now the discard action returns the following.
> 
> [arthur@test-arch ~]$ sudo fstrim -v /
> fstrim: /: the discard operation is not supported
> 
> It might be correct, but of course I was hoping the Xen VM guest would pass
> on the discard request to the block device in the Xen VM host, which is a
> disk partition.
> Any suggestions?

Hm, that's not what I did see on my testing, the operation worked OK,
and that's what I would expect to happen in your case also, since I
know the xenstore keys.

I think it's possible your email client has mangled the patch, I'm
attaching the same patch to this email, could you try to apply it
again and report back? (this time it should apply cleanly)

Thanks, Roger.

Attachment: v2-0001-xen-blkfront-allow-discard-nodes-to-be-optional.patch
Description: Text document


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.