Re: [PATCH] xen/decompress: make helper symbols static

[Jan Beulich <jbeulich@xxxxxxxx>]

On 18.01.2021 16:31, Andrew Cooper wrote:
> On 18/01/2021 15:13, Jan Beulich wrote:
>> On 18.01.2021 12:58, Andrew Cooper wrote:
>>> but I really would
>>> like to see the STATIC and INIT defines disappear eventually.
>> I too would like to, but I don't see this happen in particular
>> for INIT and INITDATA, when we have two distinct environments
>> where this code gets built. Unless you envision the tool stack /
>> stubdom side of the build to gain
>>
>> #define __init
>> #define __initdata
>>
>> ?
> 
> I think that's fine.
> 
> One way or another, some header file somewhere needs to plumb this up
> for the differing environments.  I just don't see the need for an extra
> level of indirection.

I see. Maybe I can do so while I'm touching this code anyway.

>> As far as STATIC goes, being in the middle of the DomU side
>> work of this, I've found a need to sprinkle around quite a
>> few of them in zstd/decompress.c, again to silence similar
>> compiler diagnostics.
> 
> Do you mean you've had to add more STATIC's in?

Yes indeed. Plus #ifdef out some of the functions that aren't
used at all, i.e. where with static added the compiler would
still warn. Yet I didn't want to delete code there, in order
for future changes we might want to grab from Linux to apply
reasonably.

Jan