[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/decompress: make helper symbols static
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 18 Jan 2021 11:58:30 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SdM0rYp8YYLqpoBjSUZZbjTNORqqHSV4r82hUdgKpI0=; b=ZXbx5Cd7XiBzV4hMwvytH+nU0/0HzYWkv0NNycgzkYJSqW6bpHiS8rb/C5PXvmZKjB0s9TBQrqu2lZ3cVT7GRSJZZc8rUwXd4gE26EbLiQ+0sXytYR+1jrhoiopH38nf17BbpBNr1KD3pRzQ6s+FiHcYpsuggxy+oIhfjoc8dawBb3KhmRMIyspqCk7nwUXZfpK4wciOYVz2Wg80PYWegugKf675EhTE3rtNTRZmivUnIZu8b79tUtWB2uXhlWavVCv9dIvxqOUFfSsqDXOZjbIqON/dRJFNI7Jnnqj5xAD3EjZwtEzb8b42hmM/bBkCwzCQ7M3A8QZFJQbZGbHzKg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lseb9d0iZpII43oM/LxkvP0w9oL3SYYrH9xB8aIhW/QmEbRQIwCMF9C1AuXVohBJgYgy1YVJ1p11sjoXzbaY34NJ64g6D4URhcy5ELg+1Qzo/uOPWEzKQYvbUqoKoCqp5sW1uFPgO3w5ZdAUVanAbkVGxLIXNrRoXHg3BD9bAYRB9yOZH32rUNSNBiXuAoVt5xVunRduAWu1YpAGlk2/G/AYjKgSQuczHapWDee6h+TKlqR1/yxPaxQmAMnqunGoZiyNzUpcHq6a64sk4hkTajXlpoHTcCTgDzgEsK8hn51orzxmlXJdaF/7iIBgEqRVBZo7bFTo/aJt28j/Dr6H3w==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 18 Jan 2021 11:58:44 +0000
- Ironport-sdr: g0srzw0NpNe9sTNfETbDpMVn2HjR0TKn8Sf0VgCGn4J8ka/hM9RU6zIbQxgv+bDg9kWCjbG/Rg ao+VaKyNTWnqdUcmEJS3OujKRqpr89PDnT5sWMFmclH0SmF8yI1E0Nhm18rGdc3kSjMTKj8hFh HPyWXmgcSP76qk36Cz1H7QdTgQMP/1SYracnsCC5pjwdYuOshe16r5kEmFO6BW73hqMS3Su0Bk OLBE/gRAhAXrL6vipkOga4Tvi6fXtlC5ZwofJK7JcxT4SYIMOl9LE0ThZog5yzLgQcMZiVSV93 cAY=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18/01/2021 11:19, Jan Beulich wrote:
> The individual decompression CUs need to only surface their top level
> functions to other code. Arrange for everything else to be static, to
> make sure no undue uses of that code exist or will appear without
> explicitly noticing. (In some cases this also results in code size
> reduction, but since this is all init-only code this probably doesn't
> matter very much.)
>
> In the LZO case also take the opportunity and convert u8 where lines
> get touched anyway.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> The downside is that the top level functions will now be non-static
> in stubdom builds of libxenguest, but I think that's acceptable.
Yeah - not something to lose sleep over.
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, but I really would
like to see the STATIC and INIT defines disappear eventually.
|
