[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/dpci: remove the dpci EOI timer
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 15 Jan 2021 14:19:45 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h9oZDkfqnanPlKkCw++VGDbDCCzmtk+Lb0kPDRwvNM8=; b=jXEs30vJyGLpTrbSratE12qt6U3VLASjqAhyLEBpJCyRaRxg4oLX1xFlDEvYdzEUEXAKlKgrgsVOChCHFcDaioJU7dv/fr8f5mN+lIogajYPJ56SDFhfpLFMjTgpDi63eZFmkyZBQZBPy3VnwpbT37TLjHoAEKu5g5MNbGPzNkcgvzacv/mnWDxrGa36mEx3ncTwHPyC1eUFzAkhTu1LhcTQxVCvg+XqrB8MfQocr8vQxPrEfS/G1/wymKPXTsgzm68j8LrxJWwA4W+ZMOIZoPaFsR93ve3u8onYmBDuMSuhKrWZ4V0kazfDEvY6GKheadx7jTP0zpHSvr6rYR9viA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HhOeZdj8cjGgY6m8k1pLMEAQdvNWI8uPGVSXSanlX/Xh1HQCiHTAVHP319kc54B8T5uI6iE63eOg0paymmPE9DuuvRjKmdQUVS5ObXsazwomkMheWEUpYRAlvdOFp/NM1ZCc9pCSwHOG+IGXUWC3r8xYHEq5ZH6Q6djT7TLpAkO75J4ZuywgWLd2U1u5bLrMNkd4F8sm6WEW8MeXsXSKOxAD7TSElgKa2ylpkNLgyGWJ6QTh99+tywXNkPBSjl7ICwv1ALiD43B9Cp4HEZ8lw5oTkeyF8dX4v7McR1X+zWM1MuXcq3Re/hKlCUaOaKoU2WxNsuJTdrsKyFkF+77pzQ==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 15 Jan 2021 13:20:12 +0000
- Ironport-sdr: Kv5eblr0eOLCTEpcN/7mYVNK0NSz3owu+a6k4owYENdI4kyJpTGQ7baiL+exnXZFFa1z3SxHnm 1ODahBWpaV9F6cANObb1TjjnjsdeY7OUf2wfpJ4k6//4iNA7QBqBQIfG6n0h4YvolWpsqrroGj kLnHWspTig71VBK5hUYTMpx7yMerFVpWlyA2/9xZjVHVJwwwSRlRq+DXMovb65zV6CDJPmknu9 Jy+qFWMW+yp/Ku2zZ7Mj7atyM4P1QJkqiyAvihPAD5RPlX+jEfyAOu90DElb7C5uDdWQRE19u3 5AQ=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jan 14, 2021 at 12:54:22PM +0100, Jan Beulich wrote:
> On 12.01.2021 18:32, Roger Pau Monne wrote:
> > @@ -967,10 +879,10 @@ static void hvm_pirq_eoi(struct pirq *pirq)
> > * since interrupt is still not EOIed
> > */
> > if ( --pirq_dpci->pending ||
> > - !pt_irq_need_timer(pirq_dpci->flags) )
> > + /* When the interrupt source is MSI no Ack should be performed. */
> > + pirq_dpci->flags & HVM_IRQ_DPCI_TRANSLATE )
>
> If we settle on this timer being possible to drop, then there's
> just one cosmetic issue here (which can be fixed while committing
> I suppose) - there is a pair of parentheses missing here.
I will be sending an updated version of this patch in a longer series.
I've added the parentheses instead of keeping pt_irq_need_timer, as I
would also like to get rid of HVM_IRQ_DPCI_TRANSLATE at some point and
then the change here is straightforward to perform.
Thanks, Roger.
|
