Re: [PATCH] x86/dpci: remove the dpci EOI timer

[Jan Beulich <jbeulich@xxxxxxxx>]

On 12.01.2021 18:32, Roger Pau Monne wrote:
> @@ -967,10 +879,10 @@ static void hvm_pirq_eoi(struct pirq *pirq)
>       * since interrupt is still not EOIed
>       */
>      if ( --pirq_dpci->pending ||
> -         !pt_irq_need_timer(pirq_dpci->flags) )
> +         /* When the interrupt source is MSI no Ack should be performed. */
> +         pirq_dpci->flags & HVM_IRQ_DPCI_TRANSLATE )

If we settle on this timer being possible to drop, then there's
just one cosmetic issue here (which can be fixed while committing
I suppose) - there is a pair of parentheses missing here.

Otherwise we will want to at least keep

> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -184,11 +184,6 @@ int pt_irq_destroy_bind(struct domain *, const struct 
> xen_domctl_bind_pt_irq *);
>  void hvm_dpci_isairq_eoi(struct domain *d, unsigned int isairq);
>  struct hvm_irq_dpci *domain_get_irq_dpci(const struct domain *);
>  void free_hvm_irq_dpci(struct hvm_irq_dpci *dpci);
> -#ifdef CONFIG_HVM
> -bool pt_irq_need_timer(uint32_t flags);
> -#else
> -static inline bool pt_irq_need_timer(unsigned int flags) { return false; }
> -#endif

along with making the function static in its source file.

Jan