[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] introduce unaligned.h



On 15.01.2021 12:13, Andrew Cooper wrote:
> On 15/01/2021 10:05, Jan Beulich wrote:
>> Rather than open-coding commonly used constructs in yet more places when
>> pulling in zstd decompression support (and its xxhash prereq), pull out
>> the custom bits into a commonly used header (for the hypervisor build;
>> the tool stack and stubdom builds of libxenguest will still remain in
>> need of similarly taking care of). For now this is limited to x86, where
>> custom logic isn't needed (considering this is going to be used in init
>> code only, even using alternatives patching to use MOVBE doesn't seem
>> worthwhile).
>>
>> No change in generated code.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> Iirc use of include/asm-generic/ was disliked, hence the generic header
>> goes into include/xen/.
> 
> Really?  I think its going to be the only sane way of fixing up some of
> our header tangle.

Should have responded here too: It was me to suggest to put some
header there when reviewing some patches a while ago, and iirc it
was Julien who pushed back.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.