[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] introduce unaligned.h


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 15 Jan 2021 11:13:00 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gwhlAF9/zHzzg97mcb1ohPbdAcBGDPIL3AC5jPWeyVM=; b=FYb51mBkSgbyu9hrT4kcnnw9iJig432ielhB4XMN7v+5jXcv1MQYq1AFt+8Ml1q6pWzNH+9aUI9kF5I23lZKlZfOl85c/heFqVsd4kIS3XqrsQ+BfXxPK2DPhoNA4s+5/E53l5Q/BgBShimIwAN0p/cJyMyKpUCSnS5nE2vLumBMXWnw6iqqHk2DGvCEc2hxcLLUEW2TX5x78Hc4zUnOyFbErM8taHIrTDQky293JSbMRZmq4703Z4pa4qrRJSB6FSIg7OhupE9v+thY7w0qTyMrGuI/9C3HaxGZfBNDod9R/JkC2lY3eS8m9xPN4Pl4w8sOifkh2Ihtv2P1CWsN5w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HhSlEzsT5v+bDW82zbPvkfnEbaCs61b3B8gwMdUogmC6XcUgeO7qwE1sw6XwBPGS+ffrtKZZuJZPYQZY0/05wjCryuaWaprtNaBD6Dc7S3zrQTkCFTNZiXZHp6d3sQFUs1ls3yzk+qtgMo0KqLnEaQC8xOOGT2YhaY+4Rls2Qdqf0c3qzg3BWQUH6nWqKHpeKSN8WyAdLWNniAJxUS2DQ4L9x95jMkusHdjrV1LoOoSgZE7G5zOXUjuPQrNAyON71rpC23CT0+RMfv8E2U16z4J72z4XMvcWCsPB03UIZ1shyQzE4bzVLlPRAGFe4aTZhqPQmz6fQfoDhgo5ZrXGUg==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, M A Young <m.a.young@xxxxxxxxxxxx>
  • Delivery-date: Fri, 15 Jan 2021 11:13:17 +0000
  • Ironport-sdr: 7rimZWO7FlTU+OQ1JlGWlRJfAaEAa8aFt/Hhf7E1JM8HJYpHoUnhH3ayTb40lnTeU2fEsh2zFn tXZrwK4AVN4qFnkyGJyvBEGwrksVZ3B3m6foS7d+lqA7AYVwVSJWBlhJG7IeuQRDKsArZEa/I6 W2oNIS/u3Ylj9dYSCGx1Ko2vPYyU36bdP5ri98ZZEb4raMzAdrgaBjSMbplot3hVagmujGlCp4 oeGhD1rZSMQnvIRThSULcbJsjAlPx4L7PX1RaNAQwhw8fznv3YKvYmAxhi74GRKaeBGC5SEUEW Xlo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15/01/2021 10:05, Jan Beulich wrote:
> Rather than open-coding commonly used constructs in yet more places when
> pulling in zstd decompression support (and its xxhash prereq), pull out
> the custom bits into a commonly used header (for the hypervisor build;
> the tool stack and stubdom builds of libxenguest will still remain in
> need of similarly taking care of). For now this is limited to x86, where
> custom logic isn't needed (considering this is going to be used in init
> code only, even using alternatives patching to use MOVBE doesn't seem
> worthwhile).
>
> No change in generated code.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> Iirc use of include/asm-generic/ was disliked, hence the generic header
> goes into include/xen/.

Really?  I think its going to be the only sane way of fixing up some of
our header tangle.

This series probably isn't the right place to fix this argument, so
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

However, presumably we're going to want an ARM side of this imminently?



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.