Re: [PATCH] xen/privcmd: allow fetching resource sizes

[Jürgen Groß <jgross@xxxxxxxx>]

On 12.01.21 11:03, Roger Pau Monné wrote:
> On Tue, Jan 12, 2021 at 06:57:30AM +0100, Jürgen Groß wrote:
> > On 11.01.21 16:29, Roger Pau Monne wrote:
> > > Allow issuing an IOCTL_PRIVCMD_MMAP_RESOURCE ioctl with num = 0 and
> > > addr = 0 in order to fetch the size of a specific resource.
> > >
> > > Add a shortcut to the default map resource path, since fetching the
> > > size requires no address to be passed in, and thus no VMA to setup.
> > >
> > > Fixes: 3ad0876554caf ('xen/privcmd: add IOCTL_PRIVCMD_MMAP_RESOURCE')
> > I don't think this addition is a reason to add a "Fixes:" tag. This is
> > clearly new functionality.
> It could be argued that not allowing to query the resource size was a
> shortcoming of the original implementation, but a backport request to
> stable would be more appropriate than a fixes tag I think. Will drop
> on next version and add a backport request if you agree.
Yes, please.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature