[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/privcmd: allow fetching resource sizes
- To: Jürgen Groß <jgross@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 12 Jan 2021 11:03:24 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rBkuX8FT5jUzq1WN/uGEa7TYFFxYQ7VC9+egvnGrTXM=; b=UK4PmxIg82NaO9SYSvpTwCA4K4eAgKRfTv3Po2OWPboY3NQWYJKig4mP+u/3PrKYz9u6FTe2GMF9D7/19whzg52QUJtoUZ1B4rEuJjCUtwdyYIyWM5OMOm+b6oianL69OKArCJGjC6o689Wyf/rJXxE3wMsLxiWFm8thVT4kJl4r7Q6LsT5ez8ZfMUml7O2Fto9D/VhqTAcuujurdYCo+yHAZGFcI4XRvcPe87vFrS8NFGUkepYIvbYG5tkCBE3+R224/L3VbKoFmv21Gg5wxQlRmgoyUhu8gStIoeDSwkNxMga7kO19X4Arc9QSP83ZTmR1xNjdqbUk5oK6Qa1LNw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IG8txY4Ucn51KwyOOyo85P2q59jXaZhKp5RQG/WYXftCS2BHkjrBQoUtPV9rjvVZPA+G6ZouUHHy9csElQBodgRHixkFv9LGxqXxO4jhfUrobKtMJ89z1sPgCRZxw5Yr2dHFh2tHiP+6Lc7MWNdYrjjs2Kk4TM3/gG1XYAdc+HI2E+PcY+Qfi/UB3vMoDUgBfKd8o5hAoBhfmbkvzx1gXCupAHSVhfdpBymIZNsaeVXx08BaO9e/8zuWHegibE1ajEoIptWLTQoK7g3c6adD9e/DZZFjJhdR9dEa1EtfL4064zroadyHpOWGaofR98dD+ZR4QvfqW5JRqDu9ZJslTg==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <linux-kernel@xxxxxxxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paul Durrant <paul.durrant@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 12 Jan 2021 10:03:45 +0000
- Ironport-sdr: 6/zImbji96Tlg28r5IFrvYd+x8aqpv+tT+tIyASGf3VSLNLU8emddp2uNMUiKfEo7y8ceQ2n6R 1fu2t768SReLbxnEpVg02Q/K9xHOSRiV4yS50WMEqZfGlSZva5ZucmVbl5eBHO1k94/fZiaacG TbI87UKzuv4Ak9bdrtyW6xDDNFHQwaJaNuRtgQk7SiFf6f4W63wp8phY3o6wSTHX+A6LD9kB0+ JIFbpdso2xLXlJJvDhd9vRvc3bgFVTnETfeJSzqxFKtU8MzYlUhGni+9immIRYxj227J4wZO9D gSg=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jan 12, 2021 at 06:57:30AM +0100, Jürgen Groß wrote:
> On 11.01.21 16:29, Roger Pau Monne wrote:
> > Allow issuing an IOCTL_PRIVCMD_MMAP_RESOURCE ioctl with num = 0 and
> > addr = 0 in order to fetch the size of a specific resource.
> >
> > Add a shortcut to the default map resource path, since fetching the
> > size requires no address to be passed in, and thus no VMA to setup.
> >
> > Fixes: 3ad0876554caf ('xen/privcmd: add IOCTL_PRIVCMD_MMAP_RESOURCE')
>
> I don't think this addition is a reason to add a "Fixes:" tag. This is
> clearly new functionality.
It could be argued that not allowing to query the resource size was a
shortcoming of the original implementation, but a backport request to
stable would be more appropriate than a fixes tag I think. Will drop
on next version and add a backport request if you agree.
Thanks, Roger.
|
